Skip to content

feat(profiling): reverse profile_session start/stop methods deprecation #4162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sentry_sdk/profiler/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@
)

__all__ = [
"start_profile_session",
"start_profiler", # TODO: Deprecate this in favor of `start_profile_session`
"stop_profile_session",
"stop_profiler", # TODO: Deprecate this in favor of `stop_profile_session`
"start_profile_session", # TODO: Deprecate this in favor of `start_profiler`
"start_profiler",
"stop_profile_session", # TODO: Deprecate this in favor of `stop_profiler`
"stop_profiler",
# DEPRECATED: The following was re-exported for backwards compatibility. It
# will be removed from sentry_sdk.profiler in a future release.
"MAX_PROFILE_DURATION_NS",
Expand Down
20 changes: 10 additions & 10 deletions sentry_sdk/profiler/continuous_profiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,32 +145,32 @@ def try_profile_lifecycle_trace_start():

def start_profiler():
# type: () -> None
if _scheduler is None:
return

# TODO: deprecate this as it'll be replaced by `start_profile_session`
start_profile_session()
_scheduler.manual_start()


def start_profile_session():
# type: () -> None
if _scheduler is None:
return

_scheduler.manual_start()
# TODO: deprecate this as it'll be replaced by `start_profiler`
start_profiler()


def stop_profiler():
# type: () -> None
if _scheduler is None:
return

# TODO: deprecate this as it'll be replaced by `stop_profile_session`
stop_profile_session()
_scheduler.manual_stop()


def stop_profile_session():
# type: () -> None
if _scheduler is None:
return

_scheduler.manual_stop()
# TODO: deprecate this as it'll be replaced by `stop_profiler`
stop_profiler()


def teardown_continuous_profiler():
Expand Down
Loading