Skip to content

Fix Migration Guide regarding removal of last_event_id() #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lovetox opened this issue Jun 2, 2024 · 1 comment · Fixed by #3126
Closed

Fix Migration Guide regarding removal of last_event_id() #3118

lovetox opened this issue Jun 2, 2024 · 1 comment · Fixed by #3126
Assignees
@szokeasaurusrex

Comments

@lovetox
Copy link

lovetox commented Jun 2, 2024

How do you use Sentry?

Self-hosted/on-premise

Version

2.2.0

Steps to Reproduce

Migration Guide says, method last_event_id() was removed, but it was reintroduced in 2.2.0

Expected Result

Correct Migration Guide

Actual Result

The API function last_event_id() was removed
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jun 2, 2024
szokeasaurusrex added a commit that referenced this issue Jun 3, 2024
@szokeasaurusrex
docs: Update last_event_id in migration guide
d099f5d 
Update the migration guide to mention that `last_event_id` has been reintroduced.

Fixes GH-3118
@szokeasaurusrex szokeasaurusrex mentioned this issue Jun 3, 2024
Merged
@getsantry getsantry bot removed the status in GitHub Issues with 👀 3 Jun 3, 2024
@szokeasaurusrex szokeasaurusrex self-assigned this Jun 3, 2024
@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Jun 3, 2024 •
edited
Loading

Good catch, @lovetox – I have already opened a PR to fix the migration guide as you have suggested

arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this issue Sep 30, 2024
@szokeasaurusrex @arjenzorgdoc
docs: Remove last_event_id from migration guide
a55214e 
Since we reintroduced `last_event_id` in 2.2.0, we should remove it from the migration guide.

Fixes getsentryGH-3118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
None yet
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Update last_event_id in migration guide getsentry/sentry-python
2 participants
@szokeasaurusrex @lovetox