Skip to content

Serializer trimming improvements #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sentrivana opened this issue Jul 4, 2023 · 1 comment
Closed

Serializer trimming improvements #2223

sentrivana opened this issue Jul 4, 2023 · 1 comment

Comments

@sentrivana
Copy link
Contributor

sentrivana commented Jul 4, 2023

Problem Statement

It's been coming up a lot in recent years that people are unhappy with the way our serializer auto-trims their events. The most common issues are that there is no indication in the UI that some part of the event was trimmed and that parts of objects important for debugging go missing.

As far as we know sentry-python is also the only SDK that actively trims events before sending.

Ingest will drop an event if it is too large, (see also #2223 (comment)) which should be made transparent to users (e.g. client reports) if it happens.

We've recently updated an option to skip trimming request bodies. This issue considers going one step further and removing the limits altogether, either optionally or in all cases.

Related Issues

Solution Brainstorm

  • (add a client option to) disable trimming altogether
  • consider if we need the serializer
  • make sure that it's transparent to the user if ingest drops an event due to it being too large
  • add a visual indicator to the UI that something was trimmed (if we keep the trimming)
@antonpirker
Copy link
Member

I just talked to ingest at breakfast. What happens with big payloads:

  • There is something in nginx that drops REALLY big payload. They where not sure if there will be an outcome for that.
  • Then the envelope arrives at relay and a size check is done. Eventually dropping if too big (with outcome)
  • There there is also an envelope item limit, eventually dropping the item.
  • Then relay does some truncation.
  • Then the rest of the processing

@sentrivana sentrivana modified the milestones: Sentry SDK 2.0, Data Truncation Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants