Skip to content

[Feature] add options.include; [Bugfix] fix options.exclude #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Feature] add options.include; [Bugfix] fix options.exclude #144

wants to merge 1 commit into from

Conversation

tyler-dot-earth
Copy link

Didn't find that options.exclude worked (perhaps similar to this comment). I also actually wanted options.include.

Results:

  • include seems to work how i'd expect
  • exclude seems to work how i'd expect

Room for improvement

  • testing include + exclude at same time
  • probably not the most well-integrated filtering code (i.e. maybe it'd be better off somewhere else in the code).

Open to any feedback / advice! 🎓 🍎

I'm using this in one of my own projects and it seems to be working fine now. I'll see if I can't polish it up some more in the next few days.

@tyler-dot-earth
Copy link
Author

Closing because I figured out how to get exclude working properly (here: #148 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant