Update more stuff to fprime v4.0.0a1 #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-f-ortega
requested changes
Jun 3, 2025
|
|
||
| PlatformIntType m_pin; | ||
| }; | ||
| PlatformIntType m_pin; |
There was a problem hiding this comment.
We are soon getting rid of PlatformIntType. Should replace this with int
| Fw::Success setDutyCycle_handler(const FwIndexType portNum, /*!< The port number*/ | ||
| U8 dutyCycle); | ||
|
|
||
| PlatformIntType m_pin; |
| @@ -27,22 +27,21 @@ class LifeLed : public LifeLedComponentBase { | |||
| ~LifeLed(); | |||
|
|
|||
| //! Set the arduino pin to own | |||
| void configure(PlatformIntType pin=Arduino::DEF_LED_BUILTIN); | |||
| void configure(PlatformIntType pin = Arduino::DEF_LED_BUILTIN); | |||
| void run_handler(NATIVE_INT_TYPE portNum, //!< The port number | ||
| NATIVE_UINT_TYPE context //!< The call order | ||
| void run_handler(FwIndexType portNum, //!< The port number | ||
| U32 context //!< The call order | ||
| ) override; | ||
| U16 m_blink_count; | ||
| PlatformIntType m_pin; |
|
I realize this MR is to upgrade-to-fprime-4 and not to main. Can merge this and address the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
rp2040builds are now broken becauseCMAKE_EXECUTABLE_SUFFIXcan't append the.elfextension.See #41