Skip to content

[variant] Add Generic F4xx #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 55 commits into from
Closed

Conversation

ABOSTM
Copy link

@ABOSTM ABOSTM commented Apr 2, 2021

Summary
[variant] Add Generic F4xx

Supersede stm32duino#1337

fpistm and others added 30 commits April 2, 2021 15:21
This will help to add generic board entry.
Note:
upload.maximum_size and product_line have to be verified
and changed if needed.

Signed-off-by: Frederic Pillon <[email protected]>
To avoid having duplicated variants with all the same files.

Signed-off-by: Frederic Pillon <[email protected]>
Syntax in the board.txt:
xxx.build.peripheral_pins=-DCUSTOM_PERIPHERAL_PINS

Example to use a custom peripheral pins file for Nucleo_L476RG:
    Nucleo_64.menu.pnum.NUCLEO_L476RG.build.peripheral_pins=-DCUSTOM_PERIPHERAL_PINS
Then add a file with ".c" extension like "PeripheralPins_<board>.c" in the
variantfolder.

At sketch folder:
CUSTOM_PERIPHERAL_PINS could now be overridden using the build_opt.h, ex:
-DCUSTOM_PERIPHERAL_PINS=\"PeripheralPins_NUCLEO_L476RG.c\"

Signed-off-by: Frederic Pillon <[email protected]>
- variant.* files are renamed variant_generic.*
Generic variant header file will be included thanks
a single variant.h using a variable defined in boards.txt
- Clean template to remove useless extern "C"
- Include guards replaced by #pragma once directive

Signed-off-by: Frederic Pillon <[email protected]>
By default the variant.h will include variant_generic.h file.
*.build.variant_h=variant_{build.board}.h can be added in
the boards.txt to define the dedicated header to a board.

Signed-off-by: Frederic Pillon <[email protected]>
All specific L4 variants moved to the generic variant.

Signed-off-by: Frederic Pillon <[email protected]>
All specific G4 variants moved to the generic variant.

Signed-off-by: Alexandre Bourdiol <[email protected]>
Supersede stm32duino#1236

Signed-off-by: Owen Williams <[email protected]>
Co-authored-by: Alexandre Bourdiol <[email protected]>
Nucleo G071RB and Disco G0316 moved to the generic variant.

Fix stm32duino#857

Signed-off-by: Frederic Pillon <[email protected]>
fpistm and others added 9 commits April 2, 2021 15:22
Some series require to have it defined by default (H7, MP1)

Signed-off-by: Frederic Pillon <[email protected]>
Fix stm32duino#1302

Signed-off-by: Alexandre Bourdiol <[email protected]>
Signed-off-by: Alexandre Bourdiol <[email protected]>
Supersede stm32duino#1123

Signed-off-by: Morten Kals <[email protected]>
Co-authored-by: Alexandre Bourdiol <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Alexandre Bourdiol <[email protected]>
Supersede stm32duino#1238

Signed-off-by: dnandha <[email protected]>
Co-authored-by: Alexandre Bourdiol <[email protected]>
Supersede stm32duino#1115

Signed-off-by: Stanimir Petev <[email protected]>
Co-authored-by: Alexandre Bourdiol <[email protected]>
@ABOSTM ABOSTM force-pushed the STM32F4_VARIANT branch 4 times, most recently from e8b5f07 to 8cae2aa Compare April 2, 2021 17:13
@fpistm
Copy link
Owner

fpistm commented Apr 3, 2021

One point raised on the forum which could be fixed in this PR
https://www.stm32duino.com/viewtopic.php?p=6652#p6652

@ABOSTM ABOSTM force-pushed the STM32F4_VARIANT branch from 8cae2aa to dfaf8a8 Compare April 6, 2021 09:00
ABOSTM and others added 4 commits April 6, 2021 15:06
Supersede stm32duino#1337

Signed-off-by: Alexandre Bourdiol <[email protected]>
Note this user buuton is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
Add [New variant] STM32F407ZGT6 Mini and Generic_F407Zx
Supersed stm32duino#1130

Signed-off-by: dds90 <[email protected]>
Co-authored-by: Alexandre Bourdiol <[email protected]>
Invert PF9 and PF10 in digitalPin[] to match their definition in
variant.h
Fixes forum issue:
https://www.stm32duino.com/viewtopic.php?p=6652#p6652

Signed-off-by: Alexandre Bourdiol <[email protected]>
@ABOSTM ABOSTM force-pushed the STM32F4_VARIANT branch from dfaf8a8 to 8f42825 Compare April 6, 2021 13:07
@fpistm fpistm force-pushed the subvariant branch 5 times, most recently from f320f88 to e47c39f Compare April 9, 2021 12:10
@fpistm
Copy link
Owner

fpistm commented Apr 12, 2021

Integrated to official PR.

Thanks

@fpistm fpistm closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.