Fixed reactivity of the $asyncComputed properties #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtorromeo
commented
Dec 19, 2018
|
|
||
| if (!this.$options.computed) this.$options.computed = {} | ||
|
|
||
| this.$options.computed.$asyncComputed = () => this.$data._asyncComputed |
There was a problem hiding this comment.
Note that I had to implement a little hack here using _asyncComputed in $data and a corresponding $asyncComputed computed property to maintain backwards compatibility. This is necessary since Vue does not proxy properties that start with _ or $.
Alternatives, if backwards compatibility is not needed are:
- Rename
$asyncComputedas simplyasyncComputed. - Keep only
$asyncComputedin data instead of_asyncComputed, drop the unnecessary computed property and document that it should be accessed asthis.$data.$asyncComputed.
|
@foxbenjaminfox do you think you could take a look at this, please? Happy new year! |
|
Sorry that it took me a bit of time to come back around to this project. I've merged the PR, and soon I'll release a version to NPM with the fix. |
|
It's cool, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
$asyncComputedreactive by turning it into a property of$dataand manipulating it withVue.set.This should fix #52 and #56.