Update email.js #89
Merged
Update email.js #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The promises for `signInWithEmailAndPassword` and `createUserWithEmailAndPassword` resolve with a `UserCredential` and not a user. Calling the parameter `user` is a left-over from the old (pre-5.0) SDK where it was an actual `FirebaseUser` object. I renamed the parameter and added an example of how to access the UID, which is the most common action for developers after creating an account/signing in.
|
@puf thanks for noticing this! I fixed it in a few more spots as well. Btw for every snippet in this repo there is a parallel vNext snippet. So |
samtstern
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The promises for
signInWithEmailAndPasswordandcreateUserWithEmailAndPasswordresolve with aUserCredentialand not a user. Calling the parameteruseris a left-over from the old (pre-5.0) SDK where it was an actualFirebaseUserobject.I renamed the parameter and added an example of how to access the UID, which is the most common action for developers after creating an account/signing in.
Context: https://stackoverflow.com/questions/65817351/did-firebase-createuserwithemailandpassword-change-the-return-value/65817541?noredirect=1#comment116371334_65817541