Skip to content

chore: add missing whitespace & fix an incorrect snippet #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2023
Merged

chore: add missing whitespace & fix an incorrect snippet #352

merged 2 commits into from
Jul 7, 2023

Conversation

nestiank
Copy link

@nestiank nestiank commented Jul 7, 2023

This PR is to add a whitespace into an example script.

@google-cla
Copy link

google-cla bot commented Jul 7, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@thatfiredev
Copy link
Member

@nestiank As stated at the top of the file, this file is auto-generated from database-next/read-and-write.js. Can you please edit that file instead and then run npm run snippets?

@nestiank nestiank changed the title chore: add missing whitespace chore: add missing whitespace & fix an incorrect snippet Jul 7, 2023
@nestiank
Copy link
Author

nestiank commented Jul 7, 2023

Okay, I did so, and also fixed #324 here together.

Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nestiank !

LGTM

@thatfiredev thatfiredev merged commit 7156e6c into firebase:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants