Skip to content

fix: Update ES6 firebase/app import #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2020
Merged

fix: Update ES6 firebase/app import #772

merged 1 commit into from
Oct 28, 2020

Conversation

1amageek
Copy link
Contributor

@1amageek 1amageek commented Oct 28, 2020 •
edited by bojeil-google
Loading

Updates import from:
import * as firebase from 'firebase/app'
to
import firebase from 'firebase/app'

#771

@bojeil-google bojeil-google changed the title resolve #771 fix: Update ES6 firebase/app import Oct 28, 2020
@bojeil-google bojeil-google merged commit 39230c6 into firebase:master Oct 28, 2020
@lookfirst
Copy link

@bojeil-google Please also: firebase/firebaseui-web-react#114

@bojeil-google bojeil-google mentioned this pull request Oct 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bojeil-google bojeil-google bojeil-google approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1amageek @lookfirst @bojeil-google