Skip to content

Update firebaseui dependency to support Firebase 8.0 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update firebaseui dependency to support Firebase 8.0 #115

wants to merge 3 commits into from

Conversation

gvillenave
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Nov 5, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gvillenave
Copy link
Author

@googlebot I signed it!

@gvillenave
Copy link
Author

#114

@kenta-takahashi-123
Copy link

Firebase 8.0.2 fixes iOS/Safari Indexed DB bug, so this release is very important I think.

See also:

@@ -33,10 +33,10 @@
"firebase": ">=6.3.4 <8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"firebase": ">=6.3.4 <8"
"firebase": ">=6.3.4 <9"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the package.json file in the dist directory because that's what actually gets published to npm. To update it, you can either accept my change, or run the following from the root of the directory:

npm run clean
npm i
npm run build

@jhuleatt
Copy link
Contributor

jhuleatt commented Nov 20, 2020

Thank you @gvillenave! We should be good to go once dist/package.json is updated. In the meantime, I pulled your branch and manually changed dist/package.json, and published to the beta tag on npm. For anyone that wants to try this out early, you can do it now with:

npm install react-firebaseui@beta

@jhuleatt
Copy link
Contributor

jhuleatt commented Dec 4, 2020

I created a separate PR (#122) to continue iterating on this, since I noticed a few other spots that needed changing. Let's continue over there. Thank you @gvillenave for this PR and getting this started!

@jhuleatt jhuleatt closed this Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update firebase peer dependency to support 8.x.x
4 participants