-
Notifications
You must be signed in to change notification settings - Fork 257
Update firebaseui dependency to support Firebase 8.0 #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Bump firebase peer dependency version to <9
Firebase 8.0.2 fixes iOS/Safari Indexed DB bug, so this release is very important I think. See also: |
@@ -33,10 +33,10 @@ | |||
"firebase": ">=6.3.4 <8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"firebase": ">=6.3.4 <8" | |
"firebase": ">=6.3.4 <9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the package.json
file in the dist
directory because that's what actually gets published to npm. To update it, you can either accept my change, or run the following from the root of the directory:
npm run clean
npm i
npm run build
Thank you @gvillenave! We should be good to go once npm install react-firebaseui@beta |
I created a separate PR (#122) to continue iterating on this, since I noticed a few other spots that needed changing. Let's continue over there. Thank you @gvillenave for this PR and getting this started! |
No description provided.