Skip to content

fix for build windows #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2023
Merged

fix for build windows #646

merged 1 commit into from
Mar 16, 2023

Conversation

Thaina
Copy link
Contributor

@Thaina Thaina commented Mar 7, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

  • Explicitly disable boringssl to use openssl
  • Add netstandard reference to make build success
  • Fix the call to firebase::App::RegisterLibrary which only have 2 parameter for windows platform

More details in #557


Testing

Describe how you've tested these changes.

Run python ./scripts/build_scripts/build_zips.py --use_boringssl=false --platform=windows and got zip and dll files result properly without error


Type of Change

Place an x the applicable box:

  • [ x ] Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • [ x ] Other, such as a build process or documentation change.

ps This is cmakesettings.json I need to explicitly configure in my machine

{
  "configurations": [
    {
      "name": "x64-Debug",
      "generator": "Ninja",
      "configurationType": "Debug",
      "inheritEnvironments": [ "msvc_x64_x64" ],
      "buildRoot": "${projectDir}\\out\\windows_unity\\${name}",
      "installRoot": "${projectDir}\\out\\install\\${name}",
      "cmakeCommandArgs": "",
      "buildCommandArgs": "",
      "ctestCommandArgs": "",
      "variables": [
        {
          "name": "UNITY_ROOT_DIR",
          "value": "C:/Program Files/Unity/Hub/Editor/2022.2.9f1/",
          "type": "STRING"
        },
        {
          "name": "MONO_EXE",
          "value": "C:/Program Files/Unity/Hub/Editor/2022.2.9f1/Editor/Data/MonoBleedingEdge/bin/mono.exe",
          "type": "STRING"
        },
        {
          "name": "MONO_CSHARP_BUILD_EXE",
          "value": "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/MSBuild/Current/Bin/MSBuild.exe",
          "type": "STRING"
        },
        {
          "name": "UNITY_MONO_EXE",
          "value": "C:/Program Files/Unity/Hub/Editor/2022.2.9f1/Editor/Data/MonoBleedingEdge/bin/mono.exe",
          "type": "STRING"
        },
        {
          "name": "UNITY_CSHARP_BUILD_EXE",
          "value": "C:/Program Files/Unity/Hub/Editor/2022.2.9f1/Editor/Data/MonoBleedingEdge/bin/xbuild.bat",
          "type": "STRING"
        },
        {
          "name": "ZLIB_INCLUDE_DIR",
          "value": "C:/Program Files (x86)/GnuWin32/include/",
          "type": "STRING"
        },
        {
          "name": "ZLIB_LIBRARY",
          "value": "C:/Program Files (x86)/GnuWin32/lib/zlib.lib",
          "type": "STRING"
        }
      ]
    }
  ]
}

Copy link
Collaborator

@a-maurice a-maurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. In general it seems fine, just one minor thing

@@ -191,8 +191,7 @@ static void RegisterLibrariesHelper(
const std::string& library = it->first;
const std::string& version = it->second;
firebase::App::RegisterLibrary(library.c_str(),
version.c_str(),
nullptr);
version.c_str());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a recent change to the Firebase C++ SDK, so you might just be out of date on that. https://github.com/firebase/firebase-cpp-sdk/pull/1217/files#diff-fa379ca24a0012efe3cc69026f1be97dcba3f5883f45c26cb5314f4b2c3190ee

Copy link
Contributor Author

@Thaina Thaina Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, we need to update subrepo too

But then, are there anyway we could also update subrepo along with the main repo automatically?

@a-maurice a-maurice merged commit 1d3b6cc into firebase:main Mar 16, 2023
@firebase firebase locked and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants