fix for build windows #646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
firebase::App::RegisterLibrary
which only have 2 parameter for windows platformMore details in #557
Testing
Run
python ./scripts/build_scripts/build_zips.py --use_boringssl=false --platform=windows
and got zip and dll files result properly without errorType of Change
Place an
x
the applicable box:ps This is cmakesettings.json I need to explicitly configure in my machine