Skip to content

Update Mac runners to macos-14 and Xcode to 16.2. #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update Mac runners to macos-14 and Xcode to 16.2. #1257

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0cc01cf
Update Mac runners to macos-14 and Xcode to 16.2.
jonsimantov May 20, 2025
9a8eef8
Handle Unity installing Mac Arm architecture
a-maurice May 21, 2025
fdb8bdc
Use the correct Java 11 on Mac.
jonsimantov May 21, 2025
7b407ad
Merge branch 'xcode_16' of https://github.com/firebase/firebase-unity…
jonsimantov May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ permissions: write-all
jobs:
build_android:
name: build-android-unity${{ inputs.unity_version }}-CPP${{ inputs.firebase_cpp_sdk_version }}
runs-on: macos-13
runs-on: macos-14
strategy:
fail-fast: false
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build_ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ permissions: write-all
jobs:
build_ios:
name: build-ios-unity${{ inputs.unity_version }}-CPP${{ inputs.firebase_cpp_sdk_version }}
runs-on: macos-13
runs-on: macos-14
strategy:
fail-fast: false

env:
xcodeVersion: "15.1"
xcodeVersion: "16.2"

steps:
- uses: lukka/get-cmake@latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ permissions: write-all
jobs:
build_desktop:
name: build-macOS-unity${{ inputs.unity_version}}-CPP${{ inputs.firebase_cpp_sdk_version }}
runs-on: macos-13
runs-on: macos-14
strategy:
fail-fast: false

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build_tvos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ permissions: write-all
jobs:
build_tvos:
name: build-tvos-unity${{ inputs.unity_version }}-CPP${{ inputs.firebase_cpp_sdk_version }}
runs-on: macos-13
runs-on: macos-14
strategy:
fail-fast: false

env:
xcodeVersion: "15.1"
xcodeVersion: "16.2"

steps:
- uses: lukka/get-cmake@latest
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ jobs:
fail-fast: false
matrix: ${{ fromJson(needs.check_and_prepare.outputs.build_matrix) }}
env:
xcodeVersion: "15.1"
xcodeVersion: "16.2"
steps:
- uses: lukka/get-cmake@latest
with:
Expand Down Expand Up @@ -484,7 +484,7 @@ jobs:
fail-fast: false
matrix: ${{ fromJson(needs.check_and_prepare.outputs.test_matrix) }}
env:
xcodeVersion: "15.1"
xcodeVersion: "16.2"
steps:
- id: matrix_info
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion scripts/gha/print_matrix_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@

# GitHub Runner
WINDOWS_RUNNER = "windows-latest"
MACOS_RUNNER = "macos-13"
MACOS_RUNNER = "macos-14"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating the MACOS_RUNNER to macos-14 will affect all macOS-based CI jobs. This is a potentially impactful change, and it's important to ensure it's been thoroughly validated. Could you please update the PR description with details on the following points?

  1. Testing Conducted:
    • What specific tests or workflows were run using the macos-14 runner to confirm compatibility and correctness?
    • Were there any issues encountered during testing, and how were they resolved?
  2. Xcode Version Confirmation: The PR title mentions an update to "Xcode to 16.2".
    • Does the macos-14 runner image, by default, provide Xcode 16.2, or a version that meets the project's requirements and aligns with this target?
    • If Xcode 16.2 (or another specific version) is critical and not the default on macos-14, will corresponding changes be made in the workflow files to explicitly select it (e.g., using xcode-select)? This script only defines the runner image string.
  3. Potential Impact:
    • Are there any known compatibility issues or special considerations with macos-14 or the new Xcode version that might affect the project's build, tests, or deployment processes?

Providing this information in the PR description will greatly help in understanding the change's scope and verifying its stability.

LINUX_RUNNER = "ubuntu-22.04"

PARAMETERS = {
Expand Down
Loading