-
Notifications
You must be signed in to change notification settings - Fork 929
fix(*): Fix compilation problems in my local environment #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM for messaging changes. |
The storage change is a little bit of a hack, but the typings for the "then" method are also wonky in this version of Typescript. I'm okay lying to the type system a little, but I'd add a comment explaining the cast is only there to make |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1a66849
to
b46d974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM thanks all!
Fixing three TS type errors that show up in my local build environment.
Note that even with these fixed, I still can't get the tests to pass in my local environment.