Skip to content

fix(*): Fix compilation problems in my local environment #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2017

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jul 18, 2017

Fixing three TS type errors that show up in my local build environment.

Note that even with these fixed, I still can't get the tests to pass in my local environment.

gauntface
gauntface previously approved these changes Jul 19, 2017
@gauntface
Copy link

LGTM for messaging changes.

@sphippen
Copy link
Contributor

The storage change is a little bit of a hack, but the typings for the "then" method are also wonky in this version of Typescript. I'm okay lying to the type system a little, but I'd add a comment explaining the cast is only there to make tsc happy.

@firebase firebase deleted a comment from googlebot Jul 24, 2017
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

Copy link
Contributor

@jshcrowthe jshcrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM thanks all!

@jshcrowthe jshcrowthe merged commit c8dfea3 into master Jul 24, 2017
@jshcrowthe jshcrowthe deleted the mrschmidt-fixcompile branch July 24, 2017 20:14
@firebase firebase locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants