Clears getRedirectResult() in AuthEventManager for a deleted Auth instance #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstance when it is deleted. app.auth().getRedirectResult() => resolves with redirect result provided previous page called a redirect operation. app.delete(); // deletes auth instance corresponding to app and clears redirect result. // re-initialize app with same parameters. app = firebase.initializeApp(config); app.auth().getRedirectResult() should resolve with null. This is needed for firebaseui-web react wrapper which on component unmount will delete the firebaseui instance (which deletes the internal auth instance). When the component is mounted again, the previously temp auth instance was still caching the redirect result. firebase/firebaseui-web#440 Cleans up private property access in AuthEventManager tests.
wti806
approved these changes
Jun 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears getRedirectResult() in AuthEventManager for a specified Auth instance when it is deleted.
This is needed for firebaseui-web react wrapper which on component unmount will delete the firebaseui instance (which deletes the internal auth instance). When the component is mounted again, the previously temp auth instance was still caching the redirect result.
firebase/firebaseui-web#440
Cleans up private property access in AuthEventManager tests.