Add onBlocked handler for schema upgrade #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
changed the title
schmidt-sebastian
force-pushed
the
mrschmidt-onblocked
branch
from
c847e36 to
391d47d
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-onblocked
branch
from
391d47d to
d7b7f21
Compare
mikelehen
approved these changes
Jun 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add an
onblockedhandler to our schema upgrade code. This handler gets called when another tab already has an open database connection. These connections prevent schema upgrades, but without this PR, we currently don't fail "enablePersistence()" and instead never resolve the Promise.Let me know if you think we should include the origin/host name in the error message.
FYI: There is no code that tests this codepath as our schema upgrade tests set up their own onsuccess/onfailure handlers.