Skip to content

Restore #8999 #9010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

Restore #8999 #9010

merged 2 commits into from
May 12, 2025

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 8, 2025

#8999 was rolled back in #9007 because the backend was not ready. This should be merged again when it is confirmed the backend will be able to accept the header.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 8, 2025

🦋 Changeset detected

Latest commit: a3db42e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@firebase/app-compat Minor
@firebase/app-check Minor
@firebase/app Minor
firebase Minor
@firebase/app-check-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@hsubox76 hsubox76 requested a review from egilmorez May 8, 2025 21:53
@hsubox76 hsubox76 marked this pull request as ready for review May 8, 2025 21:53
@hsubox76 hsubox76 requested review from a team as code owners May 8, 2025 21:53
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (88584fd)Merge (9515865)Diff
    browser19.5 kB19.5 kB-3 B (-0.0%)
    main20.4 kB20.4 kB-3 B (-0.0%)
    module19.5 kB19.5 kB-3 B (-0.0%)

  • @firebase/app-check

    TypeBase (88584fd)Merge (9515865)Diff
    browser26.7 kB26.9 kB+210 B (+0.8%)
    main27.7 kB27.9 kB+210 B (+0.8%)
    module26.7 kB26.9 kB+210 B (+0.8%)

  • @firebase/database-compat/standalone

    TypeBase (88584fd)Merge (9515865)Diff
    main366 kB366 kB-3 B (-0.0%)

  • bundle

    46 size changes

    TypeBase (88584fd)Merge (9515865)Diff
    analytics (logEvent)44.7 kB44.7 kB-1 B (-0.0%)
    app-check (CustomProvider)37.8 kB38.0 kB+203 B (+0.5%)
    app-check (ReCaptchaEnterpriseProvider)40.3 kB40.5 kB+203 B (+0.5%)
    app-check (ReCaptchaV3Provider)40.3 kB40.5 kB+203 B (+0.5%)
    auth (Anonymous)77.8 kB77.8 kB-1 B (-0.0%)
    auth (EmailAndPassword)87.9 kB87.9 kB-1 B (-0.0%)
    auth (GoogleFBTwitterGitHubPopup)105 kB105 kB-1 B (-0.0%)
    auth (GooglePopup)102 kB102 kB-1 B (-0.0%)
    auth (GoogleRedirect)102 kB102 kB-1 B (-0.0%)
    auth (Phone)95.3 kB95.3 kB-1 B (-0.0%)
    database (Append to a list of data)150 kB150 kB-1 B (-0.0%)
    database (Filtering data)149 kB149 kB-1 B (-0.0%)
    database (Listen for child events)165 kB165 kB-1 B (-0.0%)
    database (Listen for value events + Detach listeners)165 kB165 kB-1 B (-0.0%)
    database (Listen for value events)165 kB165 kB-1 B (-0.0%)
    database (Read data once)165 kB165 kB-1 B (-0.0%)
    database (Save data as transactions)167 kB167 kB-1 B (-0.0%)
    database (Sort data)151 kB151 kB-1 B (-0.0%)
    database (Write data)149 kB149 kB-1 B (-0.0%)
    firestore (CSI Auto Indexing Disable and Delete)275 kB275 kB-1 B (-0.0%)
    firestore (CSI Auto Indexing Enable)275 kB275 kB-1 B (-0.0%)
    firestore (Persistence)306 kB306 kB-1 B (-0.0%)
    firestore (Query Cursors)252 kB252 kB-1 B (-0.0%)
    firestore (Query)249 kB249 kB-1 B (-0.0%)
    firestore (Read data once)237 kB237 kB-1 B (-0.0%)
    firestore (Read Write w Persistence)331 kB331 kB-1 B (-0.0%)
    firestore (Realtime updates)239 kB239 kB-1 B (-0.0%)
    firestore (Transaction)216 kB216 kB-1 B (-0.0%)
    firestore (Write data)216 kB216 kB-1 B (-0.0%)
    firestore-lite (Query Cursors)105 kB105 kB-1 B (-0.0%)
    firestore-lite (Query)101 kB101 kB-1 B (-0.0%)
    firestore-lite (Read data once)76.3 kB76.3 kB-1 B (-0.0%)
    firestore-lite (Transaction)102 kB102 kB-1 B (-0.0%)
    firestore-lite (Write data)85.9 kB85.9 kB-1 B (-0.0%)
    functions (call)35.0 kB35.0 kB-1 B (-0.0%)
    messaging (send + receive)47.5 kB47.5 kB-1 B (-0.0%)
    performance (trace)62.4 kB62.4 kB-1 B (-0.0%)
    remote-config (getAndFetch)48.8 kB48.8 kB-1 B (-0.0%)
    storage (getBytes)42.8 kB42.8 kB-1 B (-0.0%)
    storage (getDownloadURL)44.9 kB44.9 kB-1 B (-0.0%)
    storage (getMetadata)44.3 kB44.3 kB-1 B (-0.0%)
    storage (list + listAll)43.8 kB43.8 kB-1 B (-0.0%)
    storage (updateMetadata)44.6 kB44.6 kB-1 B (-0.0%)
    storage (uploadBytes)49.5 kB49.5 kB-1 B (-0.0%)
    storage (uploadBytesResumable)59.4 kB59.4 kB-1 B (-0.0%)
    storage (uploadString)49.7 kB49.7 kB-1 B (-0.0%)

  • firebase

    TypeBase (88584fd)Merge (9515865)Diff
    firebase-app-check-compat.js22.9 kB23.1 kB+197 B (+0.9%)
    firebase-app-check.js25.3 kB25.5 kB+194 B (+0.8%)
    firebase-app.js103 kB103 kB-3 B (-0.0%)
    firebase-compat.js797 kB798 kB+198 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HZC5bIJGeb.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/analytics

    • getAnalytics

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps44.6 kB44.6 kB-1 B (-0.0%)

  • @firebase/app

    • getApp

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size10.2 kB10.2 kB-1 B (-0.0%)
      size-with-ext-deps25.2 kB25.2 kB-1 B (-0.0%)

    • initializeApp

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size10.1 kB10.1 kB-1 B (-0.0%)
      size-with-ext-deps25.1 kB25.1 kB-1 B (-0.0%)

    • initializeServerApp

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size12.3 kB12.3 kB-2 B (-0.0%)
      size-with-ext-deps26.3 kB26.3 kB-2 B (-0.0%)

  • @firebase/app-check

    • initializeAppCheck

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size11.5 kB11.7 kB+203 B (+1.8%)
      size-with-ext-deps36.8 kB37.0 kB+203 B (+0.6%)

  • @firebase/auth

    • getAuth

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps104 kB104 kB-1 B (-0.0%)

  • @firebase/data-connect

    • getDataConnect

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps38.8 kB38.8 kB-1 B (-0.0%)

    • subscribe

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps39.3 kB39.3 kB-1 B (-0.0%)

    • toQueryRef

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps39.0 kB39.0 kB-1 B (-0.0%)

    • validateArgs

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps38.9 kB38.9 kB-1 B (-0.0%)

  • @firebase/database

    • getDatabase

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps148 kB148 kB-1 B (-0.0%)

  • @firebase/firestore

    • getFirestore

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps96.5 kB96.5 kB-1 B (-0.0%)

  • @firebase/functions

    • getFunctions

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps28.8 kB28.8 kB-1 B (-0.0%)

  • @firebase/installations

    • getInstallations

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps34.0 kB34.0 kB-1 B (-0.0%)

  • @firebase/messaging

    • getMessaging

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps47.2 kB47.2 kB-1 B (-0.0%)

  • @firebase/performance

    • getPerformance

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps62.3 kB62.3 kB-1 B (-0.0%)

  • @firebase/remote-config

    • getRemoteConfig

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps46.6 kB46.6 kB-1 B (-0.0%)

  • @firebase/storage

    • getStorage

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps38.4 kB38.4 kB-1 B (-0.0%)

  • @firebase/vertexai

    • getVertexAI

      Size

      TypeBase (88584fd)Merge (9515865)Diff
      size-with-ext-deps28.8 kB28.8 kB-1 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/k5GdD6qDCH.html

egilmorez
egilmorez approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

@hsubox76 hsubox76 merged commit 6be75f7 into main May 12, 2025
45 of 52 checks passed
@hsubox76 hsubox76 deleted the ch-rollback-rollback branch May 12, 2025 16:42
@google-oss-bot google-oss-bot mentioned this pull request May 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egilmorez egilmorez egilmorez approved these changes

@dlarocque dlarocque dlarocque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsubox76 @google-oss-bot @egilmorez @dlarocque