Sid hybrid count token #8925
Sid hybrid count token #8925
Conversation
|
There was a problem hiding this comment.
Nice work! LGTM. I'll hold off on checking "approve" to avoid confusion with the formal approval we'll need from @hsubox76.
| @@ -298,4 +298,87 @@ describe('ChromeAdapter', () => { | |||
| }); | |||
| }); | |||
| }); | |||
| describe('countTokens', () => { | |||
| it('With no initial prompts', async () => { | |||
There was a problem hiding this comment.
Minor: describing this as a test for a singular input, eg it('counts tokens from a singular input', would be more self-explanatory from my perspective.
| ): Promise<CountTokensResponse> { | ||
| if (await chromeAdapter.isAvailable(params)) { | ||
| return (await chromeAdapter.countTokens(params)).json(); | ||
| } else { |
There was a problem hiding this comment.
Minor: unnecessary else, given the return statement above
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.