Skip to content

[Feat] Firestore onSnapshot support for bundles for feature branch. #8896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 15, 2025
Merged

[Feat] Firestore onSnapshot support for bundles for feature branch. #8896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
990c066
WIP, QuerySnapshot works in protoype function
DellaBitta Apr 4, 2025
54c89fc
Bundle snapshot loader part of overload
DellaBitta Apr 4, 2025
593e3cd
Compilation complete
DellaBitta Apr 4, 2025
8a181e1
Overloaded onSnapshot signature impl.
DellaBitta Apr 7, 2025
7588ffd
cleanup observer marshalling
DellaBitta Apr 7, 2025
10bf743
DocumentSnapshot. bundleSource & name fix
DellaBitta Apr 8, 2025
f88748f
onNext overloads and toJSON type
DellaBitta Apr 8, 2025
19990fc
itest for Snapshot created by a DocSnap bundle
DellaBitta Apr 9, 2025
099e53e
Three DocumentSnap iTests
DellaBitta Apr 9, 2025
e33c4f9
QuerySnapshot integration tests
DellaBitta Apr 9, 2025
a5ffd29
Remove extra test, added by mistake.
DellaBitta Apr 9, 2025
740b723
Update database.test.ts
DellaBitta Apr 9, 2025
c039ae2
Wait for writes in QuerySnapshot multiple events
DellaBitta Apr 10, 2025
2f27429
debug logging
DellaBitta Apr 10, 2025
8fc6c33
Timing protection QuerySnapshot tests.
DellaBitta Apr 10, 2025
4bc9bdd
format
DellaBitta Apr 10, 2025
8238cce
docs
DellaBitta Apr 10, 2025
697b6d4
Use EventsAccumulator
DellaBitta Apr 10, 2025
df3cb20
onSnapshot Observer and Error testing
DellaBitta Apr 11, 2025
a35575a
Internal function formal comments
DellaBitta Apr 11, 2025
afc7f44
PR fixes
DellaBitta Apr 12, 2025
68d49a6
Fixes for review.
DellaBitta Apr 14, 2025
078d0c4
removed typo.
DellaBitta Apr 14, 2025
c4dab65
Debug output for CI.
DellaBitta Apr 14, 2025
3ef49bb
more debug info
DellaBitta Apr 14, 2025
72e970c
...
DellaBitta Apr 14, 2025
378d1fc
...
DellaBitta Apr 14, 2025
9b2f0fe
Alt impl for setting keys.
DellaBitta Apr 14, 2025
fc8d568
Remove debug output
DellaBitta Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions common/api-review/firestore.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,46 @@ export function onSnapshot<AppModelType, DbModelType extends DocumentData>(query
// @public
export function onSnapshot<AppModelType, DbModelType extends DocumentData>(query: Query<AppModelType, DbModelType>, options: SnapshotListenOptions, onNext: (snapshot: QuerySnapshot<AppModelType, DbModelType>) => void, onError?: (error: FirestoreError) => void, onCompletion?: () => void): Unsubscribe;

// @public
export function onSnapshot<AppModelType, DbModelType extends DocumentData>(firestore: Firestore, snapshotJson: object, onNext: (snapshot: QuerySnapshot<AppModelType, DbModelType>) => void, onError?: (error: FirestoreError) => void, onCompletion?: () => void, converter?: FirestoreDataConverter<DbModelType>): Unsubscribe;

// @public
export function onSnapshot<AppModelType, DbModelType extends DocumentData>(firestore: Firestore, snapshotJson: object, onNext: (snapshot: DocumentSnapshot<AppModelType, DbModelType>) => void, onError?: (error: FirestoreError) => void, onCompletion?: () => void, converter?: FirestoreDataConverter<DbModelType>): Unsubscribe;

// @public
export function onSnapshot<AppModelType, DbModelType extends DocumentData>(firestore: Firestore, snapshotJson: object, options: SnapshotListenOptions, onNext: (snapshot: QuerySnapshot<AppModelType, DbModelType>) => void, onError?: (error: FirestoreError) => void, onCompletion?: () => void, converter?: FirestoreDataConverter<DbModelType>): Unsubscribe;

// @public
export function onSnapshot<AppModelType, DbModelType extends DocumentData>(firestore: Firestore, snapshotJson: object, options: SnapshotListenOptions, onNext: (snapshot: DocumentSnapshot<AppModelType, DbModelType>) => void, onError?: (error: FirestoreError) => void, onCompletion?: () => void, converter?: FirestoreDataConverter<DbModelType>): Unsubscribe;

// @public
export function onSnapshot<AppModelType, DbModelType extends DocumentData>(firestore: Firestore, snapshotJson: object, observer: {
next: (snapshot: QuerySnapshot<AppModelType, DbModelType>) => void;
error?: (error: FirestoreError) => void;
complete?: () => void;
}, converter?: FirestoreDataConverter<DbModelType>): Unsubscribe;

// @public
export function onSnapshot<AppModelType, DbModelType extends DocumentData>(firestore: Firestore, snapshotJson: object, observer: {
next: (snapshot: DocumentSnapshot<AppModelType, DbModelType>) => void;
error?: (error: FirestoreError) => void;
complete?: () => void;
}, converter?: FirestoreDataConverter<DbModelType>): Unsubscribe;

// @public
export function onSnapshot<AppModelType, DbModelType extends DocumentData>(firestore: Firestore, snapshotJson: object, options: SnapshotListenOptions, observer: {
next: (snapshot: QuerySnapshot<AppModelType, DbModelType>) => void;
error?: (error: FirestoreError) => void;
complete?: () => void;
}, converter?: FirestoreDataConverter<DbModelType>): Unsubscribe;

// @public
export function onSnapshot<AppModelType, DbModelType extends DocumentData>(firestore: Firestore, snapshotJson: object, options: SnapshotListenOptions, observer: {
next: (snapshot: DocumentSnapshot<AppModelType, DbModelType>) => void;
error?: (error: FirestoreError) => void;
complete?: () => void;
}, converter?: FirestoreDataConverter<DbModelType>): Unsubscribe;

// @public
export function onSnapshotsInSync(firestore: Firestore, observer: {
next?: (value: void) => void;
Expand Down
Loading
Loading