Skip to content

karma.base.js: replace "BROWSER" with "BROWSERS" in log messages, to reflect the actual name of the environment variable #8875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

karma.base.js: replace "BROWSER" with "BROWSERS" in log messages, to reflect the actual name of the environment variable #8875

merged 1 commit into from
Mar 27, 2025

Conversation

dconeybe
Copy link
Contributor

See #8491

@dconeybe
karma.base.js: replace "BROWSER" with "BROWSERS" in log messages, to …
85ac175 
…reflect the actual name of the environment variable (see #8491)
@dconeybe dconeybe self-assigned this Mar 27, 2025
@dconeybe dconeybe requested a review from a team as a code owner March 27, 2025 18:26
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: 85ac175

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dconeybe dconeybe requested a review from dlarocque March 27, 2025 18:26
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (dcc62c0) and merge commit (dc38979).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/aV5qPbZvh7.html

dlarocque
dlarocque approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@dlarocque dlarocque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (dcc62c0) and merge commit (dc38979).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7OrFKtI2b0.html

@dconeybe dconeybe merged commit 670eba6 into main Mar 27, 2025
43 of 48 checks passed
@dconeybe dconeybe deleted the dconeybe/KarmaConfBrowserMessageFix branch March 27, 2025 20:21
@firebase firebase locked and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dlarocque dlarocque dlarocque approved these changes

Assignees

@dconeybe dconeybe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @dlarocque