Remove auto-commit API report workflow

.github/workflows/check-docs.yml

@@ -22,26 +22,34 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - name: Checkout Repo
-      uses: actions/checkout@v4
-      with:
-        # get all history for the diff
-        fetch-depth: 0
-    - name: Set up Node (20)
-      uses: actions/setup-node@v4
-      with:
-        node-version: 22.10.0
-    - name: Yarn install
-      run: yarn
-    - name: Run doc generation
-      run: yarn docgen:all
-    - name: Check for changes in docs-devsite dir (fail if so)
-      run: |
-        if [[ -n "$(git status docs-devsite --porcelain)" ]]; then
-          echo "Unstaged changes detected:"
-          git status -s
-          exit 1
-        fi
-    - name: Reference documentation needs to be updated. See message below.
-      if: ${{ failure() }}
-      run: echo "Changes in this PR affect the reference docs. Run \`yarn docgen:all\` locally to regenerate docs and add them to this PR."
+      - name: Checkout Repo
+        uses: actions/checkout@v4
+        with:
+          # get all history for the diff
+          fetch-depth: 0
+      - name: Set up Node (20)
+        uses: actions/setup-node@v4
+        with:
+          node-version: 22.10.0
+      - name: Yarn install
+        run: yarn
+      - name: Run doc generation
+        run: yarn docgen:all
+        # Fail first if there are docs-devsite changes since running yarn docgen:all
+        # will also regenerate any API report changes.
+      - name: Check for changes in docs-devsite dir (fail if so)
+        run: |
+          if [[ -n "$(git status docs-devsite --porcelain)" ]]; then
+            echo "Unstaged changes detected in docs-devsite/:"
+            git status -s
+            echo "Changes in this PR affect the reference docs or API reports. Run \`yarn docgen:all\` locally to regenerate the changed files and add them to this PR."
+            exit 1
+          fi
+      - name: Check for changes in common/api-review dir (fail if so)
+        run: |
+          if [[ -n "$(git status common/api-review --porcelain)" ]]; then
+            echo "Unstaged changes detected in api-report(s):"
+            git status -s
+            echo "Changes in this PR affect the API reports. Run \`yarn build\` locally to regenerate the API reports and add them to this PR."
+            exit 1
+          fi