Skip to content

Use Node's TextEncoder in E2E JSDOM Environment #8783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

dlarocque
Copy link
Contributor

JSDOM does not provide a TextEncoder API, which causes the E2E Firestore tests to fail. To fix this, we can use Node's TextEncoder API.

Tested against the latest release 11.3.0, and confirmed that the e2e tests are now passing.

@dlarocque dlarocque requested a review from a team as a code owner February 10, 2025 19:54
Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: 131679a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v6.1

@dlarocque dlarocque merged commit 45d4274 into main Feb 10, 2025
33 checks passed
@dlarocque dlarocque deleted the dl/e2e-textencoder branch February 10, 2025 20:03
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@firebase firebase locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants