Temp rollback of PR#8718 so we can add tests before release #8751

DellaBitta · 2025-02-03T18:28:11Z

Discussion

I had merged #8718 after approved reviews, but @maneesht would like to add tests to ensure the fix doesn't affect anything, and so that we can prevent future regressions. I'm going to roll that merged PR back now since we plan to stage a release tomorrow and time is running out to add those tests.

Testing

CI.

API Changes

N/A.

changeset-bot · 2025-02-03T18:28:16Z

⚠️ No Changeset found

Latest commit: 3b153c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-02-03T18:28:26Z

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v6.1

DellaBitta · 2025-02-03T18:32:23Z

Closing because @maneesht is ok with the original change going out with the release.

google-oss-bot · 2025-02-03T18:40:51Z

Size Report ¹

Affected Products

@firebase/database
Type Base (82373b3) Merge (24e5fb4) Diff
browser 249 kB 249 kB -12 B (-0.0%)
main 254 kB 254 kB -12 B (-0.0%)
module 249 kB 249 kB -12 B (-0.0%)
@firebase/database-compat/standalone
Type Base (82373b3) Merge (24e5fb4) Diff
main 366 kB 366 kB -12 B (-0.0%)

`bundle`

Type	Base (82373b3)	Merge (`24e5fb4`)	Diff
database (Append to a list of data)	150 kB	150 kB	-12 B (-0.0%)
database (Filtering data)	148 kB	148 kB	-12 B (-0.0%)
database (Listen for child events)	165 kB	165 kB	-12 B (-0.0%)
database (Listen for value events + Detach listeners)	165 kB	165 kB	-12 B (-0.0%)
database (Listen for value events)	165 kB	165 kB	-12 B (-0.0%)
database (Read data once)	164 kB	164 kB	-12 B (-0.0%)
database (Save data as transactions)	167 kB	167 kB	-12 B (-0.0%)
database (Sort data)	150 kB	150 kB	-12 B (-0.0%)
database (Write data)	149 kB	149 kB	-12 B (-0.0%)

firebase
Type Base (82373b3) Merge (24e5fb4) Diff
firebase-compat.js 808 kB 808 kB -12 B (-0.0%)
firebase-database-compat.js 166 kB 166 kB -12 B (-0.0%)
firebase-database.js 187 kB 187 kB -12 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/rAmVmy1jbb.html

google-oss-bot · 2025-02-03T18:52:57Z

Size Analysis Report ¹

Affected Products

@firebase/database
- DataSnapshot
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 117 kB 117 kB -12 B (-0.0%)
  size-with-ext-deps 140 kB 140 kB -12 B (-0.0%)
- Database
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- OnDisconnect
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 120 kB 120 kB -12 B (-0.0%)
  size-with-ext-deps 142 kB 142 kB -12 B (-0.0%)
- QueryConstraint
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- TransactionResult
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- _QueryImpl
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- _QueryParams
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- _ReferenceImpl
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- _TEST_ACCESS_forceRestClient
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- _TEST_ACCESS_hijackHash
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- _initStandalone
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 143 kB 143 kB -12 B (-0.0%)
- _repoManagerDatabaseFromApp
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- _setSDKVersion
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- _validatePathString
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- _validateWritablePath
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- child
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- connectDatabaseEmulator
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 117 kB 117 kB -12 B (-0.0%)
  size-with-ext-deps 140 kB 140 kB -12 B (-0.0%)
- enableLogging
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- endAt
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 118 kB 118 kB -12 B (-0.0%)
  size-with-ext-deps 141 kB 141 kB -12 B (-0.0%)
- endBefore
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 119 kB 119 kB -12 B (-0.0%)
  size-with-ext-deps 141 kB 141 kB -12 B (-0.0%)
- equalTo
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 120 kB 120 kB -12 B (-0.0%)
  size-with-ext-deps 142 kB 142 kB -12 B (-0.0%)
- forceLongPolling
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- forceWebSockets
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- get
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 133 kB 133 kB -12 B (-0.0%)
  size-with-ext-deps 155 kB 155 kB -12 B (-0.0%)
- getDatabase
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 117 kB 117 kB -12 B (-0.0%)
  size-with-ext-deps 147 kB 147 kB -12 B (-0.0%)
- goOffline
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- goOnline
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- increment
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- limitToFirst
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 117 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- limitToLast
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 117 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- off
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 124 kB 124 kB -12 B (-0.0%)
  size-with-ext-deps 147 kB 147 kB -12 B (-0.0%)
- onChildAdded
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 133 kB 133 kB -12 B (-0.0%)
  size-with-ext-deps 156 kB 156 kB -12 B (-0.0%)
- onChildChanged
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 133 kB 133 kB -12 B (-0.0%)
  size-with-ext-deps 156 kB 156 kB -12 B (-0.0%)
- onChildMoved
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 133 kB 133 kB -12 B (-0.0%)
  size-with-ext-deps 156 kB 156 kB -12 B (-0.0%)
- onChildRemoved
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 133 kB 133 kB -12 B (-0.0%)
  size-with-ext-deps 156 kB 156 kB -12 B (-0.0%)
- onDisconnect
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 120 kB 120 kB -12 B (-0.0%)
  size-with-ext-deps 142 kB 142 kB -12 B (-0.0%)
- onValue
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 133 kB 133 kB -12 B (-0.0%)
  size-with-ext-deps 156 kB 156 kB -12 B (-0.0%)
- orderByChild
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 118 kB 118 kB -12 B (-0.0%)
  size-with-ext-deps 141 kB 141 kB -12 B (-0.0%)
- orderByKey
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 118 kB 118 kB -12 B (-0.0%)
  size-with-ext-deps 140 kB 140 kB -12 B (-0.0%)
- orderByPriority
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 118 kB 118 kB -12 B (-0.0%)
  size-with-ext-deps 140 kB 140 kB -12 B (-0.0%)
- orderByValue
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 118 kB 118 kB -12 B (-0.0%)
  size-with-ext-deps 140 kB 140 kB -12 B (-0.0%)
- push
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 118 kB 118 kB -12 B (-0.0%)
  size-with-ext-deps 141 kB 141 kB -12 B (-0.0%)
- query
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- ref
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- refFromURL
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 117 kB 117 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- remove
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 117 kB 117 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- runTransaction
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 135 kB 135 kB -12 B (-0.0%)
  size-with-ext-deps 158 kB 158 kB -12 B (-0.0%)
- serverTimestamp
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 116 kB 116 kB -12 B (-0.0%)
  size-with-ext-deps 138 kB 138 kB -12 B (-0.0%)
- set
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 117 kB 117 kB -12 B (-0.0%)
  size-with-ext-deps 139 kB 139 kB -12 B (-0.0%)
- setPriority
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 117 kB 117 kB -12 B (-0.0%)
  size-with-ext-deps 140 kB 140 kB -12 B (-0.0%)
- setWithPriority
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 118 kB 118 kB -12 B (-0.0%)
  size-with-ext-deps 140 kB 140 kB -12 B (-0.0%)
- startAfter
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 119 kB 119 kB -12 B (-0.0%)
  size-with-ext-deps 141 kB 141 kB -12 B (-0.0%)
- startAt
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 118 kB 118 kB -12 B (-0.0%)
  size-with-ext-deps 141 kB 141 kB -12 B (-0.0%)
- update
  Size
  Type Base (82373b3) Merge (24e5fb4) Diff
  size 118 kB 118 kB -12 B (-0.0%)
  size-with-ext-deps 141 kB 141 kB -12 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/sOuoOP6CGB.html

Temp rollback PR#8718 so we can add tests.

3b153c0

DellaBitta marked this pull request as ready for review February 3, 2025 18:28

DellaBitta requested review from a team, maneesht and aashishpatil-g as code owners February 3, 2025 18:28

dlarocque approved these changes Feb 3, 2025

View reviewed changes

DellaBitta closed this Feb 3, 2025

firebase locked and limited conversation to collaborators Mar 6, 2025

Temp rollback of PR#8718 so we can add tests before release #8751

Temp rollback of PR#8718 so we can add tests before release #8751

Conversation

DellaBitta commented Feb 3, 2025

Discussion

Testing

API Changes

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

github-actions bot commented Feb 3, 2025

Vertex AI Mock Responses Check ⚠️

DellaBitta commented Feb 3, 2025

google-oss-bot commented Feb 3, 2025

Size Report 1

Affected Products

@firebase/database

@firebase/database-compat/standalone

bundle

firebase

Test Logs

google-oss-bot commented Feb 3, 2025

Size Analysis Report 1

Affected Products

@firebase/database

DataSnapshot

Database

OnDisconnect

QueryConstraint

TransactionResult

_QueryImpl

_QueryParams

_ReferenceImpl

_TEST_ACCESS_forceRestClient

_TEST_ACCESS_hijackHash

_initStandalone

_repoManagerDatabaseFromApp

_setSDKVersion

_validatePathString

_validateWritablePath

child

connectDatabaseEmulator

enableLogging

endAt

endBefore

equalTo

forceLongPolling

forceWebSockets

get

getDatabase

goOffline

goOnline

increment

limitToFirst

limitToLast

off

onChildAdded

onChildChanged

onChildMoved

onChildRemoved

onDisconnect

onValue

orderByChild

orderByKey

orderByPriority

orderByValue

push

query

ref

refFromURL

remove

runTransaction

serverTimestamp

set

setPriority

setWithPriority

startAfter

startAt

update

Test Logs

Size Report ¹

`@firebase/database`

`@firebase/database-compat/standalone`

`bundle`

`firebase`

Size Analysis Report ¹

`@firebase/database`

`DataSnapshot`

`Database`

`OnDisconnect`

`QueryConstraint`

`TransactionResult`

`_QueryImpl`

`_QueryParams`

`_ReferenceImpl`

`_TEST_ACCESS_forceRestClient`

`_TEST_ACCESS_hijackHash`

`_initStandalone`

`_repoManagerDatabaseFromApp`

`_setSDKVersion`

`_validatePathString`

`_validateWritablePath`

`child`

`connectDatabaseEmulator`

`enableLogging`

`endAt`

`endBefore`

`equalTo`

`forceLongPolling`

`forceWebSockets`

`get`

`getDatabase`

`goOffline`

`goOnline`

`increment`

`limitToFirst`

`limitToLast`

`off`

`onChildAdded`

`onChildChanged`

`onChildMoved`

`onChildRemoved`

`onDisconnect`

`onValue`

`orderByChild`

`orderByKey`

`orderByPriority`

`orderByValue`

`push`

`query`

`ref`

`refFromURL`

`remove`

`runTransaction`

`serverTimestamp`

`set`

`setPriority`

`setWithPriority`

`startAfter`

`startAt`

`update`