Skip to content

E2E workflow: fix regex to include non-numeric #8692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jan 7, 2025

This should include tags like 11.1.0-canary.ddc3192b5 - it doesn't have to be too precise, the goal is to avoid some case where we get a sentence or error message instead of a version.

@hsubox76 hsubox76 requested a review from a team as a code owner January 7, 2025 20:21
Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: 965d3a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 changed the title fix regex to include non-numeric E2E workflow: fix regex to include non-numeric Jan 7, 2025
@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 merged commit f3a8df7 into main Jan 7, 2025
39 checks passed
@hsubox76 hsubox76 deleted the ch-npm-poll-2 branch January 7, 2025 20:39
@google-oss-bot
Copy link
Contributor

@firebase firebase locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants