Skip to content

Remove ES5 Support #8509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 25, 2024
Merged

Remove ES5 Support #8509

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
93ccada
Bump minimum target ES version to ES2017
dlarocque Sep 17, 2024
8e131d3
Remove firebase-performance-standalone-compat es5 build
dlarocque Sep 17, 2024
e5cc0d2
Generate auth docs using esm2017 typings
dlarocque Sep 17, 2024
f94c9e6
Remove esm5 from list of potential typings file directories
dlarocque Sep 17, 2024
c04c411
Remove esm5 directories from binary size reports
dlarocque Sep 17, 2024
ea3efa9
Remove esm5 from BUILD_TARGET comments
dlarocque Sep 17, 2024
de6464c
Upgrade Firestore Node CJS builds to es2017
dlarocque Sep 17, 2024
2fcbdfa
Add TODOs for ES2015 improvements
dlarocque Sep 17, 2024
3de5425
Adjust comment in installations
dlarocque Sep 17, 2024
da6aa49
Remove Firestore bundling TODO
dlarocque Sep 17, 2024
4d8deef
Formatting and minor fixes
dlarocque Sep 18, 2024
440dd9b
Fix rules-unit-testing build
dlarocque Sep 19, 2024
f45c368
Remove firebase-performance-standalone-compat.es2017.js from binary s…
dlarocque Sep 19, 2024
0b4cb9f
Disable declaration files for compat bundles
dlarocque Sep 20, 2024
b491209
Add Firestore Lite Node CJS build with build target reporting
dlarocque Sep 23, 2024
51b4060
Run formatter
dlarocque Sep 23, 2024
2719bbb
Declare docgen globals before generating docs
dlarocque Sep 23, 2024
d5ca8f9
Merge branch 'v11' into dl/es5-deprecation
dlarocque Sep 24, 2024
bb51217
Add changeset
dlarocque Sep 24, 2024
ce8859f
Fix auth internal package.json
dlarocque Sep 24, 2024
7380ecb
Format
dlarocque Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions config/tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,16 @@
"importHelpers": true,
"strict": true,
"lib": [
"es5",
"dom",
"es2015.promise",
"es2015.symbol",
"es2015.iterable",
"es2015.collection",
"es2015.symbol.wellknown",
"es2015.core",
"es2017.object",
"es2017.string",
"ESNext.WeakRef",
"es2017",
"esnext.WeakRef",
],
"module": "ES2015",
"moduleResolution": "node",
"resolveJsonModule": true,
"esModuleInterop": true,
"sourceMap": true,
"target": "es5",
"target": "es2017",
"typeRoots": [
"../node_modules/@types"
],
Expand Down
2 changes: 1 addition & 1 deletion e2e/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ module.exports = function (config) {
'resolveJsonModule': true,
'esModuleInterop': true,
'sourceMap': true,
'target': 'es5',
'target': 'es2017',
'importHelpers': true,
'noEmitOnError': true
}
Expand Down
2 changes: 1 addition & 1 deletion integration/compat-interop/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"moduleResolution": "node",
"noImplicitAny": true,
"outDir": "dist",
"target": "ES5",
"target": "es2017",
"sourceMap": true,
"esModuleInterop": true
},
Expand Down
2 changes: 1 addition & 1 deletion integration/firebase/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"moduleResolution": "node",
"noImplicitAny": true,
"outDir": "dist",
"target": "ES5",
"target": "es2017",
"sourceMap": true,
"esModuleInterop": true
},
Expand Down
2 changes: 0 additions & 2 deletions packages/analytics-compat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,10 @@
"main": "dist/index.cjs.js",
"browser": "dist/esm/index.esm2017.js",
"module": "dist/esm/index.esm2017.js",
"esm5": "dist/esm/index.esm.js",
"exports": {
".": {
"types": "./dist/src/index.d.ts",
"require": "./dist/index.cjs.js",
"esm5": "./dist/esm/index.esm.js",
"default": "./dist/esm/index.esm2017.js"
},
"./package.json": "./package.json"
Expand Down
60 changes: 21 additions & 39 deletions packages/analytics-compat/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,51 +25,33 @@ const deps = Object.keys(
Object.assign({}, pkg.peerDependencies, pkg.dependencies)
);

const es5BuildPlugins = [
const buildPlugins = [
typescriptPlugin({
typescript
}),
json()
];

const es2017BuildPlugins = [
typescriptPlugin({
typescript,
tsconfigOverride: {
compilerOptions: {
target: 'es2017'
}
}
}),
json({ preferConst: true })
];

const esmBuilds = [
{
input: 'src/index.ts',
output: {
file: pkg.browser,
format: 'es',
sourcemap: true
},
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: [...es2017BuildPlugins, emitModulePackageFile()]
const esmBuild = {
input: 'src/index.ts',
output: {
file: pkg.browser,
format: 'es',
sourcemap: true
},
{
input: 'src/index.ts',
output: { file: pkg.esm5, format: 'es', sourcemap: true },
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: [...es5BuildPlugins, emitModulePackageFile()]
}
];
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: [...buildPlugins, emitModulePackageFile()]
};

const cjsBuilds = [
{
input: 'src/index.ts',
output: { file: pkg.main, format: 'cjs', sourcemap: true },
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: es5BuildPlugins
}
];
const cjsBuild = {
input: 'src/index.ts',
output: {
file: pkg.main,
format: 'cjs',
sourcemap: true
},
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: buildPlugins
};

export default [...esmBuilds, ...cjsBuilds];
export default [esmBuild, cjsBuild];
2 changes: 0 additions & 2 deletions packages/analytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,10 @@
"main": "dist/index.cjs.js",
"browser": "dist/esm/index.esm2017.js",
"module": "dist/esm/index.esm2017.js",
"esm5": "dist/esm/index.esm.js",
"exports": {
".": {
"types": "./dist/analytics-public.d.ts",
"require": "./dist/index.cjs.js",
"esm5": "./dist/esm/index.esm.js",
"default": "./dist/esm/index.esm2017.js"
},
"./package.json": "./package.json"
Expand Down
36 changes: 9 additions & 27 deletions packages/analytics/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,39 +27,17 @@ const deps = [
...Object.keys(Object.assign({}, pkg.peerDependencies, pkg.dependencies))
];

const es5BuildPlugins = [
const buildPlugins = [
typescriptPlugin({
typescript
}),
json()
];

const es2017BuildPlugins = [
typescriptPlugin({
typescript,
tsconfigOverride: {
compilerOptions: {
target: 'es2017'
}
}
}),
json({ preferConst: true })
];

/**
* ESM builds
*/
const esmBuilds = [
{
input: 'src/index.ts',
output: [{ file: pkg.esm5, format: 'es', sourcemap: true }],
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: [
...es5BuildPlugins,
replace(generateBuildTargetReplaceConfig('esm', 5)),
emitModulePackageFile()
]
},
{
input: 'src/index.ts',
output: {
Expand All @@ -69,7 +47,7 @@ const esmBuilds = [
},
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: [
...es2017BuildPlugins,
...buildPlugins,
replace(generateBuildTargetReplaceConfig('esm', 2017)),
emitModulePackageFile()
]
Expand All @@ -82,11 +60,15 @@ const esmBuilds = [
const cjsBuilds = [
{
input: 'src/index.ts',
output: [{ file: pkg.main, format: 'cjs', sourcemap: true }],
output: {
file: pkg.main,
format: 'cjs',
sourcemap: true
},
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: [
...es5BuildPlugins,
replace(generateBuildTargetReplaceConfig('cjs', 5))
...buildPlugins,
replace(generateBuildTargetReplaceConfig('cjs', 2017))
]
}
];
Expand Down
2 changes: 1 addition & 1 deletion packages/analytics/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function registerAnalytics(): void {
);

registerVersion(name, version);
// BUILD_TARGET will be replaced by values like esm5, esm2017, cjs5, etc during the compilation
// BUILD_TARGET will be replaced by values like esm2017, cjs2017, etc during the compilation
registerVersion(name, version, '__BUILD_TARGET__');

function internalFactory(
Expand Down
2 changes: 0 additions & 2 deletions packages/app-check-compat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,10 @@
"main": "dist/index.cjs.js",
"browser": "dist/esm/index.esm2017.js",
"module": "dist/esm/index.esm2017.js",
"esm5": "dist/esm/index.esm.js",
"exports": {
".": {
"types": "./dist/src/index.d.ts",
"require": "./dist/index.cjs.js",
"esm5": "./dist/esm/index.esm.js",
"default": "./dist/esm/index.esm2017.js"
},
"./package.json": "./package.json"
Expand Down
30 changes: 8 additions & 22 deletions packages/app-check-compat/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,32 +25,14 @@ const deps = Object.keys(
Object.assign({}, pkg.peerDependencies, pkg.dependencies)
);

const es5BuildPlugins = [
const buildPlugins = [
typescriptPlugin({
typescript
}),
json()
];

const es2017BuildPlugins = [
typescriptPlugin({
typescript,
tsconfigOverride: {
compilerOptions: {
target: 'es2017'
}
}
}),
json({ preferConst: true })
];

const esmBuilds = [
{
input: 'src/index.ts',
output: { file: pkg.esm5, format: 'es', sourcemap: true },
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: [...es5BuildPlugins, emitModulePackageFile()]
},
{
input: 'src/index.ts',
output: {
Expand All @@ -59,16 +41,20 @@ const esmBuilds = [
sourcemap: true
},
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: [...es2017BuildPlugins, emitModulePackageFile()]
plugins: [...buildPlugins, emitModulePackageFile()]
}
];

const cjsBuilds = [
{
input: 'src/index.ts',
output: { file: pkg.main, format: 'cjs', sourcemap: true },
output: {
file: pkg.main,
format: 'cjs',
sourcemap: true
},
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: es5BuildPlugins
plugins: buildPlugins
}
];

Expand Down
2 changes: 0 additions & 2 deletions packages/app-check/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,10 @@
"main": "dist/index.cjs.js",
"browser": "dist/esm/index.esm2017.js",
"module": "dist/esm/index.esm2017.js",
"esm5": "dist/esm/index.esm.js",
"exports": {
".": {
"types": "./dist/app-check-public.d.ts",
"require": "./dist/index.cjs.js",
"esm5": "./dist/esm/index.esm.js",
"default": "./dist/esm/index.esm2017.js"
},
"./package.json": "./package.json"
Expand Down
30 changes: 8 additions & 22 deletions packages/app-check/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,32 +25,14 @@ const deps = Object.keys(
Object.assign({}, pkg.peerDependencies, pkg.dependencies)
);

const es5BuildPlugins = [
const buildPlugins = [
typescriptPlugin({
typescript
}),
json()
];

const es2017BuildPlugins = [
typescriptPlugin({
typescript,
tsconfigOverride: {
compilerOptions: {
target: 'es2017'
}
}
}),
json({ preferConst: true })
];

const esmBuilds = [
{
input: 'src/index.ts',
output: { file: pkg.esm5, format: 'es', sourcemap: true },
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: [...es5BuildPlugins, emitModulePackageFile()]
},
{
input: 'src/index.ts',
output: {
Expand All @@ -59,16 +41,20 @@ const esmBuilds = [
sourcemap: true
},
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: [...es2017BuildPlugins, emitModulePackageFile()]
plugins: [...buildPlugins, emitModulePackageFile()]
}
];

const cjsBuilds = [
{
input: 'src/index.ts',
output: { file: pkg.main, format: 'cjs', sourcemap: true },
output: {
file: pkg.main,
format: 'cjs',
sourcemap: true
},
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
plugins: es5BuildPlugins
plugins: buildPlugins
}
];

Expand Down
4 changes: 0 additions & 4 deletions packages/app-compat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,12 @@
"main": "dist/index.cjs.js",
"browser": "dist/esm/index.esm2017.js",
"module": "dist/esm/index.esm2017.js",
"esm5": "dist/esm/index.esm5.js",
"lite": "dist/index.lite.js",
"liteesm5": "dist/index.lite.esm5.js",
"exports": {
".": {
"types": "./dist/app-compat-public.d.ts",
"require": "./dist/index.cjs.js",
"esm5": "./dist/esm/index.esm5.js",
"lite": "./dist/index.lite.js",
"liteesm5": "./dist/index.lite.esm5.js",
"default": "./dist/esm/index.esm2017.js"
},
"./package.json": "./package.json"
Expand Down
Loading
Loading