Skip to content

[Vertex GA] Initial changes for Vertex GA packaging #8498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

hsubox76
Copy link
Contributor

Prepare repo for VertexAI GA 1.0 - packaging.

  • Update package name
  • Update token env var name

TODO:

  • Regenerate docs with new name (and remove old docs)
  • Confirm NPM token secret is up to date in Github secrets

Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: ed76792

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
firebase Major
@firebase/vertexai Major
@firebase/rules-unit-testing Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2024

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (7194d9c)Merge (ab31090)Diff
    browser18.3 kB18.3 kB-8 B (-0.0%)
    esm524.0 kB24.0 kB-8 B (-0.0%)
    main25.1 kB25.1 kB-8 B (-0.0%)
    module18.3 kB18.3 kB-8 B (-0.0%)
  • @firebase/vertexai

    TypeBase (7194d9c)Merge (ab31090)Diff
    browser?25.4 kB? (?)
    main?26.0 kB? (?)
    module?25.4 kB? (?)
  • bundle

    46 size changes

    TypeBase (7194d9c)Merge (ab31090)Diff
    analytics (logEvent)44.5 kB44.5 kB-8 B (-0.0%)
    app-check (CustomProvider)37.4 kB37.4 kB-8 B (-0.0%)
    app-check (ReCaptchaEnterpriseProvider)39.9 kB39.9 kB-8 B (-0.0%)
    app-check (ReCaptchaV3Provider)39.9 kB39.9 kB-8 B (-0.0%)
    auth (Anonymous)76.2 kB76.2 kB-8 B (-0.0%)
    auth (EmailAndPassword)84.5 kB84.5 kB-8 B (-0.0%)
    auth (GoogleFBTwitterGitHubPopup)103 kB103 kB-8 B (-0.0%)
    auth (GooglePopup)100 kB100 kB-8 B (-0.0%)
    auth (GoogleRedirect)100 kB100 kB-8 B (-0.0%)
    auth (Phone)86.9 kB86.9 kB-8 B (-0.0%)
    database (Append to a list of data)149 kB149 kB-8 B (-0.0%)
    database (Filtering data)148 kB148 kB-8 B (-0.0%)
    database (Listen for child events)164 kB164 kB-8 B (-0.0%)
    database (Listen for value events + Detach listeners)164 kB164 kB-8 B (-0.0%)
    database (Listen for value events)164 kB164 kB-8 B (-0.0%)
    database (Read data once)164 kB164 kB-8 B (-0.0%)
    database (Save data as transactions)166 kB166 kB-8 B (-0.0%)
    database (Sort data)150 kB150 kB-8 B (-0.0%)
    database (Write data)148 kB148 kB-8 B (-0.0%)
    firestore (CSI Auto Indexing Disable and Delete)272 kB272 kB-8 B (-0.0%)
    firestore (CSI Auto Indexing Enable)272 kB272 kB-8 B (-0.0%)
    firestore (Persistence)303 kB303 kB-8 B (-0.0%)
    firestore (Query Cursors)249 kB249 kB-8 B (-0.0%)
    firestore (Query)246 kB246 kB-8 B (-0.0%)
    firestore (Read data once)234 kB234 kB-8 B (-0.0%)
    firestore (Read Write w Persistence)328 kB328 kB-8 B (-0.0%)
    firestore (Realtime updates)236 kB236 kB-8 B (-0.0%)
    firestore (Transaction)214 kB214 kB-8 B (-0.0%)
    firestore (Write data)213 kB213 kB-8 B (-0.0%)
    firestore-lite (Query Cursors)91.4 kB91.4 kB-8 B (-0.0%)
    firestore-lite (Query)87.5 kB87.5 kB-8 B (-0.0%)
    firestore-lite (Read data once)63.0 kB63.0 kB-8 B (-0.0%)
    firestore-lite (Transaction)88.2 kB88.2 kB-8 B (-0.0%)
    firestore-lite (Write data)72.6 kB72.6 kB-8 B (-0.0%)
    functions (call)31.9 kB31.9 kB-8 B (-0.0%)
    messaging (send + receive)46.9 kB46.9 kB-8 B (-0.0%)
    performance (trace)51.8 kB51.7 kB-8 B (-0.0%)
    remote-config (getAndFetch)46.3 kB46.3 kB-8 B (-0.0%)
    storage (getBytes)42.1 kB42.1 kB-8 B (-0.0%)
    storage (getDownloadURL)44.1 kB44.1 kB-8 B (-0.0%)
    storage (getMetadata)43.6 kB43.6 kB-8 B (-0.0%)
    storage (list + listAll)43.0 kB43.0 kB-8 B (-0.0%)
    storage (updateMetadata)43.9 kB43.8 kB-8 B (-0.0%)
    storage (uploadBytes)48.7 kB48.7 kB-8 B (-0.0%)
    storage (uploadBytesResumable)58.7 kB58.7 kB-8 B (-0.0%)
    storage (uploadString)48.9 kB48.9 kB-8 B (-0.0%)

  • firebase

    TypeBase (7194d9c)Merge (ab31090)Diff
    firebase-app-compat.js31.8 kB31.7 kB-8 B (-0.0%)
    firebase-app.js103 kB103 kB-8 B (-0.0%)
    firebase-compat.js791 kB791 kB-8 B (-0.0%)
    firebase-performance-standalone-compat.es2017.js93.6 kB93.6 kB-8 B (-0.0%)
    firebase-performance-standalone-compat.js70.8 kB70.7 kB-8 B (-0.0%)
    firebase-vertexai.js?19.6 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/omxdpmAPnH.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2024

Size Analysis Report 1

This report is too large (178,316 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YNaBqJkoa2.html

@hsubox76 hsubox76 changed the title Initial changes for Vertex GA packaging [Vertex GA] Initial changes for Vertex GA packaging Sep 23, 2024
@hsubox76 hsubox76 marked this pull request as ready for review September 23, 2024 18:07
@hsubox76 hsubox76 requested review from a team as code owners September 23, 2024 18:07
@hsubox76 hsubox76 added this to the Vertex GA milestone Sep 23, 2024
@hsubox76 hsubox76 merged commit 097bd67 into v11 Sep 23, 2024
38 of 40 checks passed
@hsubox76 hsubox76 deleted the ch-vertex-ga branch September 23, 2024 23:28
hsubox76 added a commit that referenced this pull request Oct 17, 2024
* Add node engines fields specifying a minimum of 18 (#8457)

* Make memory lru gc the default (#8110)

* Make memory lru gc the default

* undo yarn.lock

* Make memory lru gc the default

* Fix tests

* V11 release removal of node-fetch and undici dependencies (#8492)

Our v11 release will require node 18+. Since fetch has been introduced in these node versions, we can remove our dependency on third party fetch implementations.

This change removes our usage of fetch variants undici and node-fetch for our node target builds and our CI tools.

* V11 - Remove functions node bundle (#8507)

With the removal of fetch we no long need to create a node bundle for functions. Instead the sourcebase may become isomorphic, so long as we remove the older node sources. And that's what the PR does!

* Initial changes for Vertex GA packaging (#8498)

* [Vertex GA] Rewrite Schema (#8479)

* [Vertex GA] Add new endpoint and error message. (#8497)

* [Vertex GA] Miscellaneous breaking changes for Vertex GA (#8514)

* Remove ES5 Support (#8509)

* Emit a module package file for functions ESM builds (#8517)

* Update API_NOT_ENABLED error for Vertex (#8549)

* Upgrade cjs bundles for storage and performance (#8557)

These should have been part of the bigger PR, but I missed these.

* Rollup JS files with rollup-typescript-plugin (#8503)

The rollup-typescript-plugin does not transpile JS files using the TS
compiler by default. This means that external dependencies that provide
JS bundles will not be transpiled to the target ES version specified in
the TypeScript config used by the plugin.

This resulted in one of our dependencies (https://github.com/jakearchibald/idb)
being included in the CDN bundles without being transpiled to
ES5 (the target ES version). Since this dependencies bundle uses
ES2018 syntax (object spread operator `{ ...x }`), this upgraded our CDN
bundles' minimum ES version requirement to ES2018 which isn't compatible with older browser versions.
To see the ES2018 syntax in one of the CDN bundles, see
https://www.gstatic.com/firebasejs/10.13.1/firebase-app.js and search for `...oldTraps`.

* Fix tsc errors in vertex tests (#8562)

* Make SafetySettings.method optional (#8567)

* Make SafetySettings.method optional

* Update API reports

---------

Co-authored-by: hsubox76 <[email protected]>

* [Vertex GA] Regenerate docs after Vertex GA changes (#8505)

* Close emulator file after download is complete (#8572)

* close file

* Add test:ci to end of test command in CI

* revert workflow file changes

* format

* rename vertexai package reference in a changeset (#8573)

* Missed one doc change from a PR (#8575)

* Overwrite undefined candidate index (#8577)

* Overwrite undefined candidate index

* Fix index overwrite condition to only be true when index is not a property

* Upgrade Vertex Mock Responses to V5 (#8579)

* Upgrade to mock responses v4

* Upgrade from v4 to v5 mock responses

---------

Co-authored-by: wu-hui <[email protected]>
Co-authored-by: DellaBitta <[email protected]>
Co-authored-by: Daniel La Rocque <[email protected]>
Co-authored-by: hsubox76 <[email protected]>
@firebase firebase locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants