Skip to content

Fix Storage Node tests #8443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 20, 2024
Merged

Fix Storage Node tests #8443

merged 4 commits into from
Aug 20, 2024

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Aug 20, 2024 •
edited
Loading

This is a couple of fixes to the Storage Node tests that are currently failling.

  1. FileReader was undefined in Node environments, and causing a test to fail. It turns out we don't need to use a FileReader to read a blob as a string anymore anyway, and can just replace it with the new blob.text().
  2. 'can pause uploads without an error' was failing because it was taking over 5000ms to complete. If we increase the timeout for the test to 10000ms it passes.

@dlarocque dlarocque requested review from maneesht, tonyjhuang and a team as code owners August 20, 2024 15:54
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f65709e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v3.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 20, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (1ff9661) and merge commit (b0d4107).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/V7tlrRNfAL.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 20, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (1ff9661) and merge commit (b0d4107).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DhJEhZprLK.html

hsubox76
hsubox76 reviewed Aug 20, 2024
View reviewed changes
@dlarocque dlarocque mentioned this pull request Aug 20, 2024
Open
@dlarocque dlarocque requested a review from hsubox76 August 20, 2024 17:14
@dlarocque dlarocque merged commit 12ba46f into main Aug 20, 2024
35 checks passed
@dlarocque dlarocque deleted the dl/storage-ci branch August 20, 2024 17:52
@firebase firebase locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@maneesht maneesht Awaiting requested review from maneesht maneesht is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang is a code owner

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlarocque @google-oss-bot @DellaBitta @hsubox76