Skip to content

Add linkDomain field to ActionCodeSettings #8428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 22, 2024
Merged

Add linkDomain field to ActionCodeSettings #8428

merged 4 commits into from
Aug 22, 2024

Conversation

NhienLam
Copy link
Contributor

Discussion

We are replacing FDL usage in Auth with a new hosting link. This adds a new linkDomain field to ActionCodeSettings for developers to set a custom hosting link domain.

Testing

Tested with unit tests. We will do manual testing when the backend is ready before merging to main branch.

API Changes

API proposal approved.

@NhienLam NhienLam requested a review from Xiaoshouzi-gh August 15, 2024 17:01
@NhienLam NhienLam requested review from a team, lisajian and sam-gc as code owners August 15, 2024 17:01
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 250c29b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NhienLam NhienLam removed request for a team, sam-gc and lisajian August 15, 2024 17:02
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 15, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (f7c6dc4)Merge (e36b667)Diff
    browser182 kB182 kB+465 B (+0.3%)
    cordova209 kB209 kB+467 B (+0.2%)
    esm5236 kB236 kB+467 B (+0.2%)
    main179 kB179 kB+467 B (+0.3%)
    module182 kB182 kB+465 B (+0.3%)
    react-native199 kB199 kB+467 B (+0.2%)

  • @firebase/auth-cordova

    TypeBase (f7c6dc4)Merge (e36b667)Diff
    browser209 kB209 kB+467 B (+0.2%)
    module209 kB209 kB+467 B (+0.2%)

  • @firebase/auth-web-extension

    TypeBase (f7c6dc4)Merge (e36b667)Diff
    browser137 kB137 kB+465 B (+0.3%)
    main152 kB152 kB+465 B (+0.3%)
    module137 kB137 kB+465 B (+0.3%)

  • @firebase/auth/internal

    TypeBase (f7c6dc4)Merge (e36b667)Diff
    browser193 kB193 kB+465 B (+0.2%)
    esm5249 kB250 kB+467 B (+0.2%)
    main214 kB215 kB+469 B (+0.2%)
    module193 kB193 kB+465 B (+0.2%)

  • firebase

    TypeBase (f7c6dc4)Merge (e36b667)Diff
    firebase-auth-compat.js139 kB140 kB+319 B (+0.2%)
    firebase-auth-cordova.js177 kB177 kB+391 B (+0.2%)
    firebase-auth-web-extension.js117 kB117 kB+388 B (+0.3%)
    firebase-auth.js151 kB151 kB+388 B (+0.3%)
    firebase-compat.js788 kB789 kB+320 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PfCOXB0CAO.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 15, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • AuthErrorCodes

      Size

      TypeBase (f7c6dc4)Merge (e36b667)Diff
      size44.3 kB44.4 kB+63 B (+0.1%)
      size-with-ext-deps66.0 kB66.0 kB+63 B (+0.1%)

    • debugErrorMap

      Size

      TypeBase (f7c6dc4)Merge (e36b667)Diff
      size51.4 kB51.6 kB+218 B (+0.4%)
      size-with-ext-deps73.0 kB73.3 kB+218 B (+0.3%)

    • sendEmailVerification

      Size

      TypeBase (f7c6dc4)Merge (e36b667)Diff
      size40.1 kB40.2 kB+118 B (+0.3%)
      size-with-ext-deps61.8 kB61.9 kB+119 B (+0.2%)

    • sendPasswordResetEmail

      Size

      TypeBase (f7c6dc4)Merge (e36b667)Diff
      size43.9 kB44.0 kB+118 B (+0.3%)
      size-with-ext-deps65.6 kB65.7 kB+119 B (+0.2%)

    • sendSignInLinkToEmail

      Size

      TypeBase (f7c6dc4)Merge (e36b667)Diff
      size43.9 kB44.1 kB+118 B (+0.3%)
      size-with-ext-deps65.6 kB65.7 kB+119 B (+0.2%)

    • verifyBeforeUpdateEmail

      Size

      TypeBase (f7c6dc4)Merge (e36b667)Diff
      size40.1 kB40.2 kB+118 B (+0.3%)
      size-with-ext-deps61.8 kB61.9 kB+119 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZVd4IkWXG3.html

@NhienLam
Update error message for ERROR_INVALID_HOSTING_LINK_DOMAIN to include…
bdd5a44 
… that default hosting domains cannot be used.
@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v3.1

Xiaoshouzi-gh
Xiaoshouzi-gh approved these changes Aug 22, 2024
View reviewed changes
Copy link

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NhienLam NhienLam merged commit 85ebbce into hosting-link Aug 22, 2024
38 of 40 checks passed
@NhienLam NhienLam deleted the fdl-replace branch August 22, 2024 20:36
@firebase firebase locked and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NhienLam @google-oss-bot @Xiaoshouzi-gh