Skip to content

Implement SessionToken Persistence #8391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2024
Merged

Implement SessionToken Persistence #8391

merged 3 commits into from
Jul 30, 2024

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Jul 24, 2024 •
edited
Loading

Persistence of SessionToken

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c1cc744

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tom-andersen tom-andersen marked this pull request as ready for review July 24, 2024 15:52
@tom-andersen tom-andersen requested review from a team as code owners July 24, 2024 15:52
@tom-andersen tom-andersen requested a review from wu-hui July 24, 2024 15:52
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 24, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/analytics

    TypeBase (46da093)Merge (3cf9561)Diff
    browser21.3 kB21.8 kB+531 B (+2.5%)
    esm526.6 kB27.0 kB+386 B (+1.5%)
    main28.1 kB28.4 kB+351 B (+1.3%)
    module21.3 kB21.8 kB+531 B (+2.5%)

  • @firebase/app-check

    TypeBase (46da093)Merge (3cf9561)Diff
    browser26.4 kB26.3 kB-64 B (-0.2%)
    esm531.9 kB31.6 kB-348 B (-1.1%)
    main33.2 kB32.8 kB-404 B (-1.2%)
    module26.4 kB26.3 kB-64 B (-0.2%)

  • @firebase/app-compat

    TypeBase (46da093)Merge (3cf9561)Diff
    browser5.28 kB5.28 kB+4 B (+0.1%)
    esm56.13 kB6.14 kB+4 B (+0.1%)
    main6.73 kB6.74 kB+4 B (+0.1%)
    module5.28 kB5.28 kB+4 B (+0.1%)

  • @firebase/firestore

    TypeBase (46da093)Merge (3cf9561)Diff
    browser378 kB379 kB+896 B (+0.2%)
    esm5363 kB364 kB+932 B (+0.3%)
    main582 kB583 kB+1.25 kB (+0.2%)
    module378 kB379 kB+896 B (+0.2%)
    react-native378 kB379 kB+896 B (+0.2%)

  • bundle

    13 size changes

    TypeBase (46da093)Merge (3cf9561)Diff
    analytics (logEvent)48.3 kB44.5 kB-3.82 kB (-7.9%)
    app-check (ReCaptchaEnterpriseProvider)44.0 kB39.9 kB-4.09 kB (-9.3%)
    app-check (ReCaptchaV3Provider)43.9 kB39.8 kB-4.09 kB (-9.3%)
    firestore (CSI Auto Indexing Disable and Delete)268 kB269 kB+687 B (+0.3%)
    firestore (CSI Auto Indexing Enable)268 kB269 kB+687 B (+0.3%)
    firestore (Persistence)303 kB304 kB+687 B (+0.2%)
    firestore (Query Cursors)240 kB240 kB+228 B (+0.1%)
    firestore (Query)238 kB238 kB+228 B (+0.1%)
    firestore (Read data once)226 kB226 kB+228 B (+0.1%)
    firestore (Read Write w Persistence)323 kB323 kB+687 B (+0.2%)
    firestore (Realtime updates)228 kB228 kB+228 B (+0.1%)
    firestore (Transaction)205 kB205 kB+228 B (+0.1%)
    firestore (Write data)205 kB205 kB+228 B (+0.1%)

  • firebase

    TypeBase (46da093)Merge (3cf9561)Diff
    firebase-analytics-compat.js29.9 kB26.5 kB-3.41 kB (-11.4%)
    firebase-analytics.js33.7 kB29.7 kB-4.01 kB (-11.9%)
    firebase-app-check-compat.js27.0 kB23.4 kB-3.67 kB (-13.6%)
    firebase-app-check.js29.4 kB25.0 kB-4.40 kB (-15.0%)
    firebase-app-compat.js31.7 kB31.7 kB+4 B (+0.0%)
    firebase-app.js102 kB102 kB+175 B (+0.2%)
    firebase-compat.js789 kB787 kB-2.71 kB (-0.3%)
    firebase-firestore-compat.js341 kB342 kB+662 B (+0.2%)
    firebase-firestore.js437 kB438 kB+896 B (+0.2%)
    firebase-performance-standalone-compat.js70.6 kB70.6 kB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kgDhXw0Ogu.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 24, 2024 •
edited
Loading

Size Analysis Report 1

This report is too large (349,043 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/asnRwCZax0.html

wu-hui
wu-hui reviewed Jul 29, 2024
View reviewed changes
packages/firestore/test/unit/local/globals_cache.test.ts
@@ -0,0 +1,84 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a schema upgrade test for web? I think so..can you check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing migration tests: 14>15, 15>16 and 16>17.

@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Jul 29, 2024
@tom-andersen tom-andersen requested a review from wu-hui July 29, 2024 16:46
@wu-hui wu-hui removed their assignment Jul 30, 2024
@tom-andersen tom-andersen merged commit 6bb2e89 into main Jul 30, 2024
43 checks passed
@tom-andersen tom-andersen deleted the tomandersen/sessionToken branch July 30, 2024 15:32
@firebase firebase locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@tom-andersen tom-andersen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-andersen @google-oss-bot @wu-hui