Skip to content

b/79432277: Limit Queries to only a single array-contains clause. #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2018

Conversation

mikelehen
Copy link
Contributor

Note: The doc comment change I made in Android is missing because array-contains isn't in the .d.ts yet.

Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I debated asking you to change the error message from "Queries only support having a single array-contains filter" to "Queries only support a single array-contains filter" but then you will never finish porting.

@mikelehen
Copy link
Contributor Author

Heh. The 'having' actually bugged me in the iOS port I am about to send you and so I went ahead and removed it there and here. I'll probably leave it in Android for now though.

@mikelehen mikelehen merged commit 04c9c3a into master May 16, 2018
@mikelehen mikelehen deleted the mikelehen/array-contains-restriction branch May 16, 2018 23:45
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants