-
Notifications
You must be signed in to change notification settings - Fork 928
Fix FirebaseServerApp Typescript exactOptionalPropertyTypes error #8341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
292dcb7
ServerAppSettings name now aligns with AppSettings
DellaBitta cafed75
Omit name from FirebaseServerAppSettings.
DellaBitta e321fde
changeset
DellaBitta b71a10f
Minor bump `firebase` in the changeset.
DellaBitta 5ff07dd
Generate refdocs
dlarocque 2b23355
format
DellaBitta 815ab15
Merge branch 'master' into ddb-firebaseserverappsettings-name
DellaBitta d331af4
Update API reports
DellaBitta 62a1cce
docs
DellaBitta ef0f1bb
Update `name?` to `name`
DellaBitta ad7a9ad
Update changeset
DellaBitta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
'firebase': patch | ||
'@firebase/app': patch | ||
--- | ||
|
||
The `FirebaseServerAppSettings.name` field inherited from `FirebaseAppSettings` is now omitted | ||
instead of overloading the value as `undefined`. This fixes a TypeScript compilation error. For more | ||
information, see [GitHub Issue #8336](https://github.com/firebase/firebase-js-sdk/issues/8336). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently I missed the doc generate step on the user-created PR that added this function (#8315). My bad.