Skip to content

VertexAI: migrate test cases to use updated set of golden files #8324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2024
Merged

VertexAI: migrate test cases to use updated set of golden files #8324

merged 2 commits into from
Jun 20, 2024

Conversation

tanzimfh
Copy link
Contributor

@tanzimfh tanzimfh commented Jun 18, 2024 •
edited
Loading

This updates VertexAI unit tests to work with the golden files that will be shared with Android and iOS. Some golden files were edited for consistency with the other SDKs and with what the model actually returns.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4c168db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024 •
edited
Loading

Changeset File Check ⚠️

  • Changeset formatting error in following file:%0A %0A Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.%0A If this change doesn't need a release, run `changeset add --empty`.%0A %0A

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 18, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (576c1b1) and merge commit (8eaad46).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ps3XScWYau.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 18, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (576c1b1) and merge commit (8eaad46).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DLevHS9vh1.html

@tanzimfh tanzimfh marked this pull request as ready for review June 19, 2024 13:51
@tanzimfh tanzimfh requested a review from a team as a code owner June 19, 2024 13:51
@dlarocque dlarocque requested a review from hsubox76 June 19, 2024 14:07
@tanzimfh tanzimfh merged commit ca41391 into master Jun 20, 2024
33 of 34 checks passed
@tanzimfh tanzimfh deleted the tanzim/migration branch June 20, 2024 19:52
@firebase firebase locked and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@dlarocque dlarocque dlarocque approved these changes

@rlazo rlazo Awaiting requested review from rlazo

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanzimfh @google-oss-bot @hsubox76 @dlarocque