Skip to content

Remove VertexAIError related entries from TOC #8300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jun 5, 2024

These entries were introduced when the toc.yaml was first added to the repository here: #8257

The uploaded file was generated in the vertexaierror branch (not merged). Since it wasn't tracked by Git, we weren't able to notice that there were new entries. This shouldn't happen again now that we have the checks in place.

Note: The changes being removed here haven't been uploaded to devsite, so the change is only on GitHub

@dlarocque dlarocque requested a review from a team as a code owner June 5, 2024 19:36
Copy link

changeset-bot bot commented Jun 5, 2024

⚠️ No Changeset found

Latest commit: c473407

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@egilmorez egilmorez requested a review from rachelsaunders June 5, 2024 20:26
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LG, just let's make sure Rachel reviews any CL submitting this to the live site, thanks!

@dlarocque dlarocque merged commit a90255a into master Jun 5, 2024
34 checks passed
@dlarocque dlarocque deleted the dlarocque/fix-toc branch June 5, 2024 20:55
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants