-
Notifications
You must be signed in to change notification settings - Fork 929
Convert supported mimetypes to be bullet points #8270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Changeset File Check
|
Size Report 1Affected ProductsNo changes between base commit (08a3a93) and merge commit (1c48ba8).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (08a3a93) and merge commit (1c48ba8).Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Daniel!
Would it be possible to test the generation, and then put a link to the staged/rendered output in the PR description?
I often do that as "Staged internally at ."
I had trouble getting the bulleted list to render correctly, so I converted it to be a full sentence since there were only two bullets. If you prefer a bulleted list for this, could you share an example of how to get it to render correctly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now! Bullets not essential, thanks!
.changeset/unlucky-radios-invent.md
Outdated
@@ -0,0 +1,2 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need a changeset for documentation changes.
Convert supported mimetypes in the reference documentation to be bulleted.