Set up rollup for webchannel-wrapper #8203

hsubox76 · 2024-04-24T20:26:54Z

Replace gulp CLI + closure + rollup with just rollup CLI.

Create ESM versions of CJS closure-net files and configure package.jsons to point to the correct ESM, CJS, and ES5 paths.

Create an empty main entry point file (empty.js) for any CI or application that requires there to be a main entry point.

Tested with some apps

plain webpack
new Vite app
new Next app

changeset-bot · 2024-04-24T20:26:58Z

⚠️ No Changeset found

Latest commit: cdf7d75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2024-04-24T20:42:00Z

Size Report ¹

Affected Products

@firebase/webchannel-wrapper
Type Base (f3bc8f5) Merge (c426ad8) Diff
main 55.0 kB 38 B -55.0 kB (-99.9%)
@firebase/webchannel-wrapper/bloom-blob
Type Base (f3bc8f5) Merge (c426ad8) Diff
main ? 11.1 kB ? (?)
@firebase/webchannel-wrapper/webchannel-blob
Type Base (f3bc8f5) Merge (c426ad8) Diff
main ? 44.3 kB ? (?)

`bundle`

Type	Base (`f3bc8f5`)	Merge (`c426ad8`)	Diff
firestore (CSI Auto Indexing Disable and Delete)	270 kB	270 kB	+154 B (+0.1%)
firestore (CSI Auto Indexing Enable)	270 kB	270 kB	+154 B (+0.1%)
firestore (Persistence)	305 kB	305 kB	+154 B (+0.1%)
firestore (Query Cursors)	248 kB	248 kB	+154 B (+0.1%)
firestore (Query)	246 kB	246 kB	+154 B (+0.1%)
firestore (Read data once)	234 kB	234 kB	+154 B (+0.1%)
firestore (Read Write w Persistence)	324 kB	324 kB	+154 B (+0.0%)
firestore (Realtime updates)	236 kB	237 kB	+154 B (+0.1%)
firestore (Transaction)	213 kB	213 kB	+154 B (+0.1%)
firestore (Write data)	213 kB	213 kB	+154 B (+0.1%)

firebase
Type Base (f3bc8f5) Merge (c426ad8) Diff
firebase-compat.js 787 kB 787 kB +151 B (+0.0%)
firebase-firestore-compat.js 343 kB 343 kB +146 B (+0.0%)
firebase-firestore.js 437 kB 437 kB +151 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/IUDoRAYfKQ.html

google-oss-bot · 2024-04-24T20:54:17Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- AbstractUserDataWriter
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 97.6 kB 97.8 kB +154 B (+0.2%)
- AggregateField
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.5 kB 89.7 kB +154 B (+0.2%)
- AggregateQuerySnapshot
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.6 kB 89.8 kB +154 B (+0.2%)
- Bytes
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 91.0 kB 91.1 kB +154 B (+0.2%)
- CACHE_SIZE_UNLIMITED
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.4 kB 89.6 kB +154 B (+0.2%)
- CollectionReference
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 93.1 kB 93.3 kB +154 B (+0.2%)
- DocumentReference
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 93.1 kB 93.3 kB +154 B (+0.2%)
- DocumentSnapshot
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 96.6 kB 96.8 kB +154 B (+0.2%)
- FieldPath
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 92.1 kB 92.3 kB +154 B (+0.2%)
- FieldValue
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.5 kB 89.6 kB +154 B (+0.2%)
- Firestore
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.4 kB 89.6 kB +154 B (+0.2%)
- FirestoreError
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.4 kB 89.6 kB +154 B (+0.2%)
- GeoPoint
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 90.0 kB 90.2 kB +154 B (+0.2%)
- LoadBundleTask
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 90.3 kB 90.4 kB +154 B (+0.2%)
- PersistentCacheIndexManager
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.5 kB 89.7 kB +154 B (+0.2%)
- Query
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.6 kB 89.7 kB +154 B (+0.2%)
- QueryCompositeFilterConstraint
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 91.7 kB 91.8 kB +154 B (+0.2%)
- QueryConstraint
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.4 kB 89.6 kB +154 B (+0.2%)
- QueryDocumentSnapshot
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 96.6 kB 96.8 kB +154 B (+0.2%)
- QueryEndAtConstraint
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 115 kB 115 kB +154 B (+0.1%)
- QueryFieldFilterConstraint
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 113 kB 113 kB +154 B (+0.1%)
- QueryLimitConstraint
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 90.2 kB 90.4 kB +154 B (+0.2%)
- QueryOrderByConstraint
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 90.6 kB 90.8 kB +154 B (+0.2%)
- QuerySnapshot
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 98.6 kB 98.7 kB +154 B (+0.2%)
- QueryStartAtConstraint
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 115 kB 115 kB +154 B (+0.1%)
- SnapshotMetadata
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.6 kB 89.7 kB +154 B (+0.2%)
- Timestamp
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 90.6 kB 90.8 kB +154 B (+0.2%)
- Transaction
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 124 kB 124 kB +154 B (+0.1%)
- WriteBatch
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 120 kB 120 kB +154 B (+0.1%)
- _AutoId
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.4 kB 89.6 kB +154 B (+0.2%)
- _ByteString
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 90.5 kB 90.6 kB +154 B (+0.2%)
- _DatabaseId
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.4 kB 89.6 kB +154 B (+0.2%)
- _DocumentKey
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 98.8 kB 99.0 kB +154 B (+0.2%)
- _EmptyAppCheckTokenProvider
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.5 kB 89.7 kB +154 B (+0.2%)
- _EmptyAuthCredentialsProvider
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.4 kB 89.6 kB +154 B (+0.2%)
- _FieldPath
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 91.9 kB 92.0 kB +154 B (+0.2%)
- _TestingHooks
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.9 kB 90.1 kB +154 B (+0.2%)
- _cast
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 90.2 kB 90.4 kB +154 B (+0.2%)
- _debugAssert
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.4 kB 89.6 kB +154 B (+0.2%)
- _isBase64Available
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.5 kB 89.6 kB +154 B (+0.2%)
- _logWarn
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.5 kB 89.7 kB +154 B (+0.2%)
- _validateIsNotUsedTogether
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.4 kB 89.6 kB +154 B (+0.2%)
- addDoc
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 204 kB 204 kB +154 B (+0.1%)
- aggregateFieldEqual
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.8 kB 89.9 kB +154 B (+0.2%)
- aggregateQuerySnapshotEqual
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 113 kB 113 kB +154 B (+0.1%)
- and
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 115 kB 115 kB +154 B (+0.1%)
- arrayRemove
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 103 kB 103 kB +154 B (+0.1%)
- arrayUnion
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 103 kB 103 kB +154 B (+0.1%)
- average
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 93.2 kB 93.3 kB +154 B (+0.2%)
- clearIndexedDbPersistence
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 98.4 kB 98.6 kB +154 B (+0.2%)
- collection
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 93.9 kB 94.1 kB +154 B (+0.2%)
- collectionGroup
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 92.9 kB 93.0 kB +154 B (+0.2%)
- connectFirestoreEmulator
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 91.8 kB 92.0 kB +154 B (+0.2%)
- count
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.6 kB 89.7 kB +154 B (+0.2%)
- deleteAllPersistentCacheIndexes
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 167 kB 167 kB +154 B (+0.1%)
- deleteDoc
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 195 kB 195 kB +154 B (+0.1%)
- deleteField
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.8 kB 90.0 kB +154 B (+0.2%)
- disableNetwork
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 183 kB 183 kB +154 B (+0.1%)
- disablePersistentCacheIndexAutoCreation
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 167 kB 167 kB +154 B (+0.1%)
- doc
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 94.0 kB 94.1 kB +154 B (+0.2%)
- documentId
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 92.2 kB 92.3 kB +154 B (+0.2%)
- enableIndexedDbPersistence
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 260 kB 260 kB +154 B (+0.1%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 296 kB 296 kB +154 B (+0.1%)
- enableNetwork
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 183 kB 183 kB +154 B (+0.1%)
- enablePersistentCacheIndexAutoCreation
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 167 kB 167 kB +154 B (+0.1%)
- endAt
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 115 kB 116 kB +154 B (+0.1%)
- endBefore
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 115 kB 116 kB +154 B (+0.1%)
- ensureFirestoreConfigured
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.5 kB 89.7 kB +154 B (+0.2%)
- executeWrite
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 194 kB 194 kB +154 B (+0.1%)
- getAggregateFromServer
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 190 kB 190 kB +154 B (+0.1%)
- getCountFromServer
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 190 kB 191 kB +154 B (+0.1%)
- getDoc
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 225 kB 225 kB +154 B (+0.1%)
- getDocFromCache
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 175 kB 175 kB +154 B (+0.1%)
- getDocFromServer
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 225 kB 225 kB +154 B (+0.1%)
- getDocs
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 226 kB 226 kB +154 B (+0.1%)
- getDocsFromCache
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 182 kB 183 kB +154 B (+0.1%)
- getDocsFromServer
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 226 kB 226 kB +154 B (+0.1%)
- getFirestore
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 99.7 kB 99.9 kB +154 B (+0.2%)
- getPersistentCacheIndexManager
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 90.7 kB 90.8 kB +154 B (+0.2%)
- increment
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 90.3 kB 90.5 kB +154 B (+0.2%)
- initializeFirestore
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 90.8 kB 91.0 kB +154 B (+0.2%)
- limit
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 90.4 kB 90.5 kB +154 B (+0.2%)
- limitToLast
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 90.4 kB 90.6 kB +154 B (+0.2%)
- loadBundle
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 193 kB 193 kB +154 B (+0.1%)
- memoryEagerGarbageCollector
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 165 kB 165 kB +154 B (+0.1%)
- memoryLocalCache
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 180 kB 180 kB +154 B (+0.1%)
- memoryLruGarbageCollector
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 172 kB 172 kB +154 B (+0.1%)
- namedQuery
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 168 kB 168 kB +154 B (+0.1%)
- onSnapshot
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 227 kB 227 kB +154 B (+0.1%)
- onSnapshotsInSync
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 216 kB 216 kB +154 B (+0.1%)
- or
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 115 kB 115 kB +154 B (+0.1%)
- orderBy
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 94.2 kB 94.3 kB +154 B (+0.2%)
- persistentLocalCache
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 257 kB 257 kB +154 B (+0.1%)
- persistentMultipleTabManager
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 293 kB 293 kB +154 B (+0.1%)
- persistentSingleTabManager
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 257 kB 257 kB +154 B (+0.1%)
- query
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 115 kB 115 kB +154 B (+0.1%)
- queryEqual
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 112 kB 113 kB +154 B (+0.1%)
- refEqual
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 93.4 kB 93.5 kB +154 B (+0.2%)
- runTransaction
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 204 kB 204 kB +154 B (+0.1%)
- serverTimestamp
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.7 kB 89.9 kB +154 B (+0.2%)
- setDoc
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 203 kB 203 kB +154 B (+0.1%)
- setIndexConfiguration
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 171 kB 171 kB +154 B (+0.1%)
- setLogLevel
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.4 kB 89.6 kB +154 B (+0.2%)
- snapshotEqual
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 118 kB 118 kB +154 B (+0.1%)
- startAfter
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 115 kB 116 kB +154 B (+0.1%)
- startAt
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 115 kB 116 kB +154 B (+0.1%)
- sum
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 93.2 kB 93.3 kB +154 B (+0.2%)
- terminate
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 89.7 kB 89.9 kB +154 B (+0.2%)
- updateDoc
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 204 kB 204 kB +154 B (+0.1%)
- waitForPendingWrites
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 184 kB 184 kB +154 B (+0.1%)
- where
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 114 kB 114 kB +154 B (+0.1%)
- writeBatch
  Size
  Type Base (f3bc8f5) Merge (c426ad8) Diff
  size-with-ext-deps 205 kB 206 kB +154 B (+0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/f6HapMY5G8.html

DellaBitta

Approved. Hoping the CI failures are flakes!

packages/webchannel-wrapper/rollup.config.js

* Add closure library blobs as Firestore dependency. * Remove our compilation of Closure. * Add closure-net as a git submodule. * remove temporary .only in test. * prettier. * add yarn.lock differences. * create a types.d.ts for the webchannel-wrapper package. * Bring back the aggregated types and implementations for size report. * Undo CI changes for git submodules. * Remove the git submodule. * Use git+https in package.json devDependencies. * prettier. * Set up rollup for webchannel-wrapper (#8203) * convert webchannel-wrapper package to use rollup * clean up rollup config * formatting * Create thick-spoons-check.md * Better changeset. * Address feedback on versioning. --------- Co-authored-by: Christina Holland <[email protected]>

hsubox76 added 2 commits April 24, 2024 13:11

convert webchannel-wrapper package to use rollup

c6c1f9f

clean up rollup config

1f64d7d

hsubox76 marked this pull request as ready for review April 24, 2024 20:27

hsubox76 requested review from a team as code owners April 24, 2024 20:27

DellaBitta approved these changes Apr 24, 2024

View reviewed changes

packages/webchannel-wrapper/rollup.config.js Outdated Show resolved Hide resolved

formatting

cdf7d75

DellaBitta approved these changes Apr 24, 2024

View reviewed changes

ehsannas approved these changes Apr 26, 2024

View reviewed changes

ehsannas merged commit 6834524 into ehsann/closure-net Apr 26, 2024
41 checks passed

ehsannas deleted the ch-webchannel-rollup branch April 26, 2024 21:30

ehsannas mentioned this pull request Apr 26, 2024

Use closure-net as a dependency of Firestore #8190

Merged

firebase locked and limited conversation to collaborators May 27, 2024

Set up rollup for webchannel-wrapper #8203

Set up rollup for webchannel-wrapper #8203

Conversation

hsubox76 commented Apr 24, 2024 • edited Loading

changeset-bot bot commented Apr 24, 2024 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Apr 24, 2024 • edited Loading

Size Report 1

Affected Products

@firebase/webchannel-wrapper

@firebase/webchannel-wrapper/bloom-blob

@firebase/webchannel-wrapper/webchannel-blob

bundle

firebase

Test Logs

google-oss-bot commented Apr 24, 2024 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/firestore

AbstractUserDataWriter

AggregateField

AggregateQuerySnapshot

Bytes

CACHE_SIZE_UNLIMITED

CollectionReference

DocumentReference

DocumentSnapshot

FieldPath

FieldValue

Firestore

FirestoreError

GeoPoint

LoadBundleTask

PersistentCacheIndexManager

Query

QueryCompositeFilterConstraint

QueryConstraint

QueryDocumentSnapshot

QueryEndAtConstraint

QueryFieldFilterConstraint

QueryLimitConstraint

QueryOrderByConstraint

QuerySnapshot

QueryStartAtConstraint

SnapshotMetadata

Timestamp

Transaction

WriteBatch

_AutoId

_ByteString

_DatabaseId

_DocumentKey

_EmptyAppCheckTokenProvider

_EmptyAuthCredentialsProvider

_FieldPath

_TestingHooks

_cast

_debugAssert

_isBase64Available

_logWarn

_validateIsNotUsedTogether

addDoc

aggregateFieldEqual

aggregateQuerySnapshotEqual

and

arrayRemove

arrayUnion

average

clearIndexedDbPersistence

collection

collectionGroup

connectFirestoreEmulator

count

deleteAllPersistentCacheIndexes

deleteDoc

deleteField

disableNetwork

disablePersistentCacheIndexAutoCreation

doc

documentId

hsubox76 commented Apr 24, 2024 •

edited

Loading

changeset-bot bot commented Apr 24, 2024 •

edited

Loading

google-oss-bot commented Apr 24, 2024 •

edited

Loading

Size Report ¹

`@firebase/webchannel-wrapper`

`@firebase/webchannel-wrapper/bloom-blob`

`@firebase/webchannel-wrapper/webchannel-blob`

`bundle`

`firebase`

google-oss-bot commented Apr 24, 2024 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`AbstractUserDataWriter`

`AggregateField`

`AggregateQuerySnapshot`

`Bytes`

`CACHE_SIZE_UNLIMITED`

`CollectionReference`

`DocumentReference`

`DocumentSnapshot`

`FieldPath`

`FieldValue`

`Firestore`

`FirestoreError`

`GeoPoint`

`LoadBundleTask`

`PersistentCacheIndexManager`

`Query`

`QueryCompositeFilterConstraint`

`QueryConstraint`

`QueryDocumentSnapshot`

`QueryEndAtConstraint`

`QueryFieldFilterConstraint`

`QueryLimitConstraint`

`QueryOrderByConstraint`

`QuerySnapshot`

`QueryStartAtConstraint`

`SnapshotMetadata`

`Timestamp`

`Transaction`

`WriteBatch`

`_AutoId`

`_ByteString`

`_DatabaseId`

`_DocumentKey`

`_EmptyAppCheckTokenProvider`

`_EmptyAuthCredentialsProvider`

`_FieldPath`

`_TestingHooks`

`_cast`

`_debugAssert`

`_isBase64Available`

`_logWarn`

`_validateIsNotUsedTogether`

`addDoc`

`aggregateFieldEqual`

`aggregateQuerySnapshotEqual`

`and`

`arrayRemove`

`arrayUnion`

`average`

`clearIndexedDbPersistence`

`collection`

`collectionGroup`

`connectFirestoreEmulator`

`count`

`deleteAllPersistentCacheIndexes`

`deleteDoc`

`deleteField`

`disableNetwork`

`disablePersistentCacheIndexAutoCreation`

`doc`

`documentId`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`enablePersistentCacheIndexAutoCreation`

`endAt`

`endBefore`

`ensureFirestoreConfigured`