Skip to content

Enable first npm publish #8120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2024
Merged

Enable first npm publish #8120

merged 4 commits into from
Apr 4, 2024

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Apr 3, 2024 •
edited
Loading

  • add wombot publishing token secret to all workflows
  • make sure release script doesn't block on publishing a new npm package, if the version is 0.0.1
  • rename Vertex => VertexAI

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 56cf2de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review April 3, 2024 23:27
@hsubox76 hsubox76 requested a review from a team as a code owner April 3, 2024 23:28
@hsubox76 hsubox76 requested a review from DellaBitta April 3, 2024 23:28
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 3, 2024 •
edited
Loading

Size Report 1

Affected Products

  • firebase

    TypeBase (e946e73)Merge (2fd9346)Diff
    firebase-vertexai.js17.5 kB17.5 kB+8 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ykVF4x9yxG.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 3, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • BlockReason

      Dependency

      TypeBase (e946e73)Merge (2fd9346)Diff
      classes

      VertexService

      VertexAIService

      + VertexAIService
- VertexService

    • ChatSession

      Dependency

      TypeBase (e946e73)Merge (2fd9346)Diff
      classes

      ChatSession
RequestUrl
VertexService

      ChatSession
RequestUrl
VertexAIService

      + VertexAIService
- VertexService

    • FinishReason

      Dependency

      TypeBase (e946e73)Merge (2fd9346)Diff
      classes

      VertexService

      VertexAIService

      + VertexAIService
- VertexService

    • FunctionDeclarationSchemaType

      Dependency

      TypeBase (e946e73)Merge (2fd9346)Diff
      classes

      VertexService

      VertexAIService

      + VertexAIService
- VertexService

    • GenerativeModel

      Dependency

      TypeBase (e946e73)Merge (2fd9346)Diff
      classes

      ChatSession
GenerativeModel
RequestUrl
VertexService

      ChatSession
GenerativeModel
RequestUrl
VertexAIService

      + VertexAIService
- VertexService

    • HarmBlockThreshold

      Dependency

      TypeBase (e946e73)Merge (2fd9346)Diff
      classes

      VertexService

      VertexAIService

      + VertexAIService
- VertexService

    • HarmCategory

      Dependency

      TypeBase (e946e73)Merge (2fd9346)Diff
      classes

      VertexService

      VertexAIService

      + VertexAIService
- VertexService

    • HarmProbability

      Dependency

      TypeBase (e946e73)Merge (2fd9346)Diff
      classes

      VertexService

      VertexAIService

      + VertexAIService
- VertexService

    • POSSIBLE_ROLES

      Dependency

      TypeBase (e946e73)Merge (2fd9346)Diff
      classes

      VertexService

      VertexAIService

      + VertexAIService
- VertexService

    • getGenerativeModel

      Dependency

      TypeBase (e946e73)Merge (2fd9346)Diff
      classes

      ChatSession
GenerativeModel
RequestUrl
VertexService

      ChatSession
GenerativeModel
RequestUrl
VertexAIService

      + VertexAIService
- VertexService

    • getVertexAI

      Size

      TypeBase (e946e73)Merge (2fd9346)Diff
      size?3.14 kB? (?)
      size-with-ext-deps?28.1 kB? (?)

      Dependency

      TypeBase (e946e73)Merge (2fd9346)Diff
      functions?

      getVertexAI
registerVertex

      		?
      classes?

      VertexAIService

      		?
      variables?

      12 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockThreshold
HarmCategory
HarmProbability
Task
VERTEX_TYPE
name
version

      		?
      enums??

      External Dependency

      ModuleBase (e946e73)Merge (2fd9346)Diff
      @firebase/app?

      _getProvider
_registerComponent
getApp
registerVersion

      		?
      @firebase/component?

      Component

      		?
      @firebase/util?

      ErrorFactory
getModularInstance

      		?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LEBWP0CZ81.html

DellaBitta
DellaBitta approved these changes Apr 4, 2024
View reviewed changes
packages/vertexai/src/models/generative-model.test.ts Outdated

const fakeVertex: Vertex = {
const fakeVertex: VertexAI = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: fakeVertexAI? Not important though.

@hsubox76 hsubox76 merged commit d27cd8e into ch-vertex-feature Apr 4, 2024
@hsubox76 hsubox76 deleted the ch-vertex-publish branch April 4, 2024 19:25
@firebase firebase locked and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @DellaBitta