Skip to content

Quick fix for FirebaseServerApp#toJSON #8109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 2, 2024
Merged

Quick fix for FirebaseServerApp#toJSON #8109

merged 4 commits into from
Apr 2, 2024

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Mar 28, 2024 •
edited
Loading

  • FirebaseServerApp should not be JSON serializable
  • While I'm in here initalization => initialization

@jamesdaniels jamesdaniels requested a review from a team as a code owner March 28, 2024 18:40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 6d8ed33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/app Patch
@firebase/app-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamesdaniels jamesdaniels requested a review from DellaBitta March 28, 2024 18:40
DellaBitta
DellaBitta approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changeset please.

@jamesdaniels jamesdaniels requested review from a team as code owners March 28, 2024 18:45
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 28, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (c6ecac8)Merge (e4f89e8)Diff
    browser18.0 kB18.1 kB+26 B (+0.1%)
    esm523.6 kB23.6 kB+68 B (+0.3%)
    main24.6 kB24.7 kB+68 B (+0.3%)
    module18.0 kB18.1 kB+26 B (+0.1%)

  • firebase

    TypeBase (c6ecac8)Merge (e4f89e8)Diff
    firebase-app-compat.js31.4 kB31.4 kB+10 B (+0.0%)
    firebase-app.js102 kB102 kB+50 B (+0.0%)
    firebase-compat.js786 kB786 kB+10 B (+0.0%)
    firebase-performance-standalone-compat.es2017.js93.3 kB93.3 kB+10 B (+0.0%)
    firebase-performance-standalone-compat.js70.3 kB70.3 kB+33 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1LaYxgYHoD.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 28, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/app

    • initializeServerApp

      Size

      TypeBase (c6ecac8)Merge (e4f89e8)Diff
      size11.2 kB11.2 kB+26 B (+0.2%)
      size-with-ext-deps25.1 kB25.1 kB+26 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Lrzj9y8Hxv.html

egilmorez
egilmorez approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the typo, thanks!

@jamesdaniels jamesdaniels merged commit 6d31930 into master Apr 2, 2024
@jamesdaniels jamesdaniels deleted the jamesdanielsServerAppToJSON branch April 2, 2024 16:53
@google-oss-bot google-oss-bot mentioned this pull request Apr 9, 2024
Merged
@firebase firebase locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@egilmorez egilmorez egilmorez approved these changes

@DellaBitta DellaBitta DellaBitta approved these changes

@markarndt markarndt Awaiting requested review from markarndt

@kevinthecheung kevinthecheung Awaiting requested review from kevinthecheung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesdaniels @google-oss-bot @egilmorez @DellaBitta