-
Notifications
You must be signed in to change notification settings - Fork 927
Fix CSI timestamp issue #8090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CSI timestamp issue #8090
Conversation
🦋 Changeset detectedLatest commit: 7fb399b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (98,221 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Can I also ask you do add some tests to index_manager.test.ts, where we simply reproduce the user's case.
packages/firestore/test/unit/index/firestore_index_value_writer.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Can you add an entry to release note? |
Changeset File Check ✅
|
fix #8031
Problem:
CSI returns incorrect results for query that indexes Timestamp fields, because of the format difference, ie, 2024-01-02T03:04:05Z vs 2024-01-02T03:04:05.00000000Z.
Fix: