[FirebaseServerApp] Remove authIDTokenVerified method #8089

DellaBitta · 2024-03-22T15:27:35Z

Discussion

We're rethinking how this functionality should be used. It might reside in its own function.

Remove the method for now.

Testing

CI.
This method currently has no implementation, anyway.

API Changes

N/A.

We're rethinking how this functionality should be used. It might reside in its own function.

changeset-bot · 2024-03-22T15:27:57Z

⚠️ No Changeset found

Latest commit: 76e7937

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2024-03-22T15:44:13Z

Size Report ¹

Affected Products

@firebase/app
Type Base (e3e3339) Merge (c9f7ba2) Diff
browser 18.1 kB 18.0 kB -80 B (-0.4%)
esm5 23.6 kB 23.5 kB -122 B (-0.5%)
main 24.7 kB 24.6 kB -122 B (-0.5%)
module 18.1 kB 18.0 kB -80 B (-0.4%)

`bundle`

Type	Base (`e3e3339`)	Merge (`c9f7ba2`)	Diff
auth (Anonymous)	76.0 kB	76.0 kB	-11 B (-0.0%)
auth (EmailAndPassword)	84.3 kB	84.3 kB	-11 B (-0.0%)
auth (GoogleFBTwitterGitHubPopup)	103 kB	103 kB	-11 B (-0.0%)
auth (GooglePopup)	100 kB	100 kB	-11 B (-0.0%)
auth (GoogleRedirect)	101 kB	101 kB	-11 B (-0.0%)
auth (Phone)	86.6 kB	86.6 kB	-11 B (-0.0%)

`firebase`

Type	Base (`e3e3339`)	Merge (`c9f7ba2`)	Diff
firebase-app-compat.js	31.4 kB	31.4 kB	-80 B (-0.3%)
firebase-app.js	102 kB	102 kB	-131 B (-0.1%)
firebase-compat.js	786 kB	786 kB	-80 B (-0.0%)
firebase-performance-standalone-compat.es2017.js	93.3 kB	93.2 kB	-80 B (-0.1%)
firebase-performance-standalone-compat.js	70.4 kB	70.3 kB	-103 B (-0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/E1IJF7rtHn.html

google-oss-bot · 2024-03-22T15:55:07Z

Size Analysis Report ¹

Affected Products

@firebase/app
- _isFirebaseServerApp
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size 8.41 kB 8.40 kB -11 B (-0.1%)
  size-with-ext-deps 17.9 kB 17.8 kB -11 B (-0.1%)
- initializeServerApp
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size 11.3 kB 11.2 kB -69 B (-0.6%)
  size-with-ext-deps 25.1 kB 25.0 kB -69 B (-0.3%)
@firebase/auth
- ActionCodeOperation
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.9 kB 60.9 kB -11 B (-0.0%)
- ActionCodeURL
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 62.0 kB 61.9 kB -11 B (-0.0%)
- AuthCredential
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.9 kB 60.9 kB -11 B (-0.0%)
- AuthErrorCodes
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 65.8 kB 65.7 kB -11 B (-0.0%)
- EmailAuthCredential
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 66.6 kB 66.6 kB -11 B (-0.0%)
- EmailAuthProvider
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 68.3 kB 68.3 kB -11 B (-0.0%)
- FacebookAuthProvider
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 65.7 kB 65.7 kB -11 B (-0.0%)
- FactorId
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.6 kB -11 B (-0.0%)
- GithubAuthProvider
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 65.7 kB 65.7 kB -11 B (-0.0%)
- GoogleAuthProvider
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 65.7 kB 65.7 kB -11 B (-0.0%)
- OAuthCredential
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 62.8 kB 62.8 kB -11 B (-0.0%)
- OAuthProvider
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 66.6 kB 66.6 kB -11 B (-0.0%)
- OperationType
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.7 kB -11 B (-0.0%)
- PhoneAuthCredential
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 62.8 kB 62.8 kB -11 B (-0.0%)
- PhoneAuthProvider
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 64.5 kB 64.5 kB -11 B (-0.0%)
- PhoneMultiFactorGenerator
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.5 kB 61.5 kB -11 B (-0.0%)
- ProviderId
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.7 kB -11 B (-0.0%)
- RecaptchaVerifier
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 67.6 kB 67.6 kB -11 B (-0.0%)
- SAMLAuthProvider
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 67.0 kB 66.9 kB -11 B (-0.0%)
- SignInMethod
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.8 kB 60.8 kB -11 B (-0.0%)
- TotpMultiFactorGenerator
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 63.2 kB 63.1 kB -11 B (-0.0%)
- TotpSecret
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.6 kB 61.6 kB -11 B (-0.0%)
- TwitterAuthProvider
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 65.7 kB 65.7 kB -11 B (-0.0%)
- applyActionCode
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.7 kB -11 B (-0.0%)
- beforeAuthStateChanged
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.7 kB -11 B (-0.0%)
- browserLocalPersistence
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 64.1 kB 64.1 kB -11 B (-0.0%)
- browserPopupRedirectResolver
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 85.8 kB 85.8 kB -11 B (-0.0%)
- browserSessionPersistence
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 64.1 kB 64.1 kB -11 B (-0.0%)
- checkActionCode
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.9 kB 61.9 kB -11 B (-0.0%)
- confirmPasswordReset
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.0 kB 61.0 kB -11 B (-0.0%)
- connectAuthEmulator
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 62.4 kB 62.4 kB -11 B (-0.0%)
- createUserWithEmailAndPassword
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 65.8 kB 65.8 kB -11 B (-0.0%)
- debugErrorMap
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 72.8 kB 72.8 kB -11 B (-0.0%)
- deleteUser
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.6 kB -11 B (-0.0%)
- fetchSignInMethodsForEmail
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.0 kB 61.0 kB -11 B (-0.0%)
- getAdditionalUserInfo
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 62.0 kB 62.0 kB -11 B (-0.0%)
- getAuth
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 102 kB 102 kB -11 B (-0.0%)
- getIdToken
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.7 kB -11 B (-0.0%)
- getIdTokenResult
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.6 kB 60.6 kB -11 B (-0.0%)
- getMultiFactorResolver
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 63.5 kB 63.5 kB -11 B (-0.0%)
- getRedirectResult
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 68.3 kB 68.3 kB -11 B (-0.0%)
- inMemoryPersistence
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.6 kB 60.6 kB -11 B (-0.0%)
- indexedDBLocalPersistence
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 68.1 kB 68.1 kB -11 B (-0.0%)
- initializeAuth
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.4 kB 61.4 kB -11 B (-0.0%)
- initializeRecaptchaConfig
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 64.0 kB 63.9 kB -11 B (-0.0%)
- isSignInWithEmailLink
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 62.1 kB 62.1 kB -11 B (-0.0%)
- linkWithCredential
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.7 kB 61.7 kB -11 B (-0.0%)
- linkWithPhoneNumber
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 65.2 kB 65.2 kB -11 B (-0.0%)
- linkWithPopup
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 71.9 kB 71.8 kB -11 B (-0.0%)
- linkWithRedirect
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 67.0 kB 67.0 kB -11 B (-0.0%)
- multiFactor
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 62.8 kB 62.8 kB -11 B (-0.0%)
- onAuthStateChanged
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.7 kB -11 B (-0.0%)
- onIdTokenChanged
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.7 kB -11 B (-0.0%)
- parseActionCodeURL
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 62.0 kB 62.0 kB -11 B (-0.0%)
- prodErrorMap
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.6 kB 60.6 kB -11 B (-0.0%)
- reauthenticateWithCredential
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 62.3 kB 62.3 kB -11 B (-0.0%)
- reauthenticateWithPhoneNumber
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 65.9 kB 65.9 kB -11 B (-0.0%)
- reauthenticateWithPopup
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 72.0 kB 72.0 kB -11 B (-0.0%)
- reauthenticateWithRedirect
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 66.8 kB 66.8 kB -11 B (-0.0%)
- reload
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.6 kB 60.6 kB -11 B (-0.0%)
- revokeAccessToken
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.7 kB -11 B (-0.0%)
- sendEmailVerification
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.6 kB 61.6 kB -11 B (-0.0%)
- sendPasswordResetEmail
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 65.4 kB 65.3 kB -11 B (-0.0%)
- sendSignInLinkToEmail
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 65.4 kB 65.4 kB -11 B (-0.0%)
- setPersistence
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.7 kB -11 B (-0.0%)
- signInAnonymously
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.8 kB 61.8 kB -11 B (-0.0%)
- signInWithCredential
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 62.1 kB 62.0 kB -11 B (-0.0%)
- signInWithCustomToken
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.7 kB 61.7 kB -11 B (-0.0%)
- signInWithEmailAndPassword
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 70.1 kB 70.0 kB -11 B (-0.0%)
- signInWithEmailLink
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 70.1 kB 70.0 kB -11 B (-0.0%)
- signInWithPhoneNumber
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 65.6 kB 65.6 kB -11 B (-0.0%)
- signInWithPopup
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 71.9 kB 71.9 kB -11 B (-0.0%)
- signInWithRedirect
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 66.5 kB 66.5 kB -11 B (-0.0%)
- signOut
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.6 kB -11 B (-0.0%)
- unlink
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.2 kB 61.2 kB -11 B (-0.0%)
- updateCurrentUser
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.7 kB -11 B (-0.0%)
- updateEmail
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.0 kB 61.0 kB -11 B (-0.0%)
- updatePassword
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.9 kB 60.9 kB -11 B (-0.0%)
- updatePhoneNumber
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.5 kB 61.4 kB -11 B (-0.0%)
- updateProfile
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.1 kB 61.1 kB -11 B (-0.0%)
- useDeviceLanguage
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.7 kB -11 B (-0.0%)
- validatePassword
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 60.7 kB 60.7 kB -11 B (-0.0%)
- verifyBeforeUpdateEmail
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.6 kB 61.6 kB -11 B (-0.0%)
- verifyPasswordResetCode
  Size
  Type Base (e3e3339) Merge (c9f7ba2) Diff
  size-with-ext-deps 61.9 kB 61.9 kB -11 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/Xu9T4AmlAI.html

Remove authIDTokenVerified

76e7937

We're rethinking how this functionality should be used. It might reside in its own function.

DellaBitta requested a review from jamesdaniels March 22, 2024 15:27

jamesdaniels approved these changes Mar 22, 2024

View reviewed changes

DellaBitta marked this pull request as ready for review March 22, 2024 17:50

DellaBitta requested review from egilmorez, markarndt, kevinthecheung and a team as code owners March 22, 2024 17:50

DellaBitta merged commit 9f74ac9 into feature-firebaseserverapp Mar 22, 2024

DellaBitta deleted the ddb-remove-authtokenverified branch March 22, 2024 17:50

firebase locked and limited conversation to collaborators Apr 22, 2024

[FirebaseServerApp] Remove authIDTokenVerified method #8089

[FirebaseServerApp] Remove authIDTokenVerified method #8089

Uh oh!

Conversation

DellaBitta commented Mar 22, 2024

Discussion

Testing

API Changes

Uh oh!

changeset-bot bot commented Mar 22, 2024

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Mar 22, 2024

Size Report 1

Affected Products

@firebase/app

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Mar 22, 2024

Size Analysis Report 1

Affected Products

@firebase/app

_isFirebaseServerApp

initializeServerApp

@firebase/auth

ActionCodeOperation

ActionCodeURL

AuthCredential

AuthErrorCodes

EmailAuthCredential

EmailAuthProvider

FacebookAuthProvider

FactorId

GithubAuthProvider

GoogleAuthProvider

OAuthCredential

OAuthProvider

OperationType

PhoneAuthCredential

PhoneAuthProvider

PhoneMultiFactorGenerator

ProviderId

RecaptchaVerifier

SAMLAuthProvider

SignInMethod

TotpMultiFactorGenerator

TotpSecret

TwitterAuthProvider

applyActionCode

beforeAuthStateChanged

browserLocalPersistence

browserPopupRedirectResolver

browserSessionPersistence

checkActionCode

confirmPasswordReset

connectAuthEmulator

createUserWithEmailAndPassword

debugErrorMap

deleteUser

fetchSignInMethodsForEmail

getAdditionalUserInfo

getAuth

getIdToken

getIdTokenResult

getMultiFactorResolver

getRedirectResult

inMemoryPersistence

indexedDBLocalPersistence

initializeAuth

initializeRecaptchaConfig

isSignInWithEmailLink

linkWithCredential

linkWithPhoneNumber

linkWithPopup

linkWithRedirect

multiFactor

onAuthStateChanged

onIdTokenChanged

Size Report ¹

`@firebase/app`

`bundle`

`firebase`

Size Analysis Report ¹

`@firebase/app`

`_isFirebaseServerApp`

`initializeServerApp`

`@firebase/auth`

`ActionCodeOperation`

`ActionCodeURL`

`AuthCredential`

`AuthErrorCodes`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`FactorId`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`OperationType`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`ProviderId`

`RecaptchaVerifier`

`SAMLAuthProvider`

`SignInMethod`

`TotpMultiFactorGenerator`

`TotpSecret`

`TwitterAuthProvider`

`applyActionCode`

`beforeAuthStateChanged`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`checkActionCode`

`confirmPasswordReset`

`connectAuthEmulator`

`createUserWithEmailAndPassword`

`debugErrorMap`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`inMemoryPersistence`

`indexedDBLocalPersistence`

`initializeAuth`

`initializeRecaptchaConfig`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`prodErrorMap`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`revokeAccessToken`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`signInWithPhoneNumber`