Skip to content

Update CI node.js versions to 20.x #8055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c02f5c1
Update node version to 20 for support scripts that don't run tests.
DellaBitta Mar 5, 2024
42e5e8f
e2e test CI workflow v20 bump.
DellaBitta Mar 5, 2024
49a0c9e
temp run e2e tests on push
DellaBitta Mar 5, 2024
a19c33b
revert e2e push trigger
DellaBitta Mar 5, 2024
bf1c48e
Make test-changed always run.
DellaBitta Mar 5, 2024
98e7e97
format
DellaBitta Mar 5, 2024
e30d7fd
Emulator script uses 127.0.0.1
DellaBitta Mar 5, 2024
080adc4
test-changed-auth and auth emulator upgrade
DellaBitta Mar 5, 2024
42bcf0b
revert localhost change in emulator.test.ts in auth
DellaBitta Mar 5, 2024
692c65c
Update node for test-changed-auth firefox, too.
DellaBitta Mar 5, 2024
b1903a1
Update fcm to 20.0
DellaBitta Mar 6, 2024
6721ffb
revert check-changeset to check formatting.
DellaBitta Mar 6, 2024
5235f32
changeset formatting problem wasn't due to node 20.
DellaBitta Mar 6, 2024
f6e3131
Add an empty changeset.
DellaBitta Mar 6, 2024
70dec64
Test Firestore integration upgrade
DellaBitta Mar 6, 2024
30730b0
Test changed Firestore upgrade
DellaBitta Mar 6, 2024
7d01612
Test changed misc upgrade
DellaBitta Mar 6, 2024
ac1f67c
Update rules-unit-testing functions node engine requirement.
DellaBitta Mar 6, 2024
d39425d
Upgrade test changed workflow
DellaBitta Mar 6, 2024
23721d2
Update changed firestore and test connectFirestoreEmulator calls
DellaBitta Mar 6, 2024
9dff0fd
Update test-all workflow with node 20.
DellaBitta Mar 6, 2024
453d4f4
revert "@DellaBitta Make test-changed always run."
DellaBitta Mar 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/violet-ways-judge.md

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected to be empty?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our changeset checker fails on finding no changeset file, which it shouldn't. But this PR doesn't need a changeset because it only affects tests and workflows.

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
4 changes: 2 additions & 2 deletions .github/workflows/canary-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
with:
# Canary release script requires git history and tags.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Yarn install
run: yarn
- name: Deploy canary
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-changeset.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ jobs:
with:
# This makes Actions fetch all Git history so check_changeset script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Yarn install
run: yarn
- name: Run changeset script
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
with:
# get all history for the diff
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Yarn install
run: yarn
- name: Run doc generation (devsite docs)
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-pkg-paths.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Yarn install
run: yarn
- name: Yarn build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up node (18)
- name: Set up node (20)
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
- name: Yarn install
run: yarn
- name: Deploy project config if needed
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ jobs:
steps:
- name: Checkout Repo
uses: actions/checkout@master
- name: Set up Node (18)
- name: Set up Node (20)
uses: actions/setup-node@master
with:
node-version: 18.x
node-version: 20.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
with:
# get all history for the diff
fetch-depth: 0
- name: Set up node (16)
- name: Set up node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Yarn install
run: yarn
- name: Run formatting script
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/health-metrics-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- uses: 'google-github-actions/auth@v0'
with:
credentials_json: '${{ secrets.GCP_SA_KEY }}'
Expand All @@ -58,7 +58,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- uses: 'google-github-actions/auth@v0'
with:
credentials_json: '${{ secrets.GCP_SA_KEY }}'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Set up node (16)
- name: Set up node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: yarn install
run: yarn
- name: yarn lint
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/prerelease-manual-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ jobs:
with:
# Canary release script requires git history and tags.
fetch-depth: 0
- name: Set up node (16)
- name: Set up node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Yarn install
run: yarn
- name: Deploy prerelease
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-log.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ jobs:
- name: Checkout Repo
uses: actions/checkout@master

- name: Setup Node.js 16.x
- name: Setup Node.js 20.x
uses: actions/setup-node@master
with:
node-version: 16.x
node-version: 20.x

- name: Get PR number and send to tracker.
run: node scripts/ci/log-changesets.js
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ jobs:
# This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
fetch-depth: 0

- name: Setup Node.js 16.x
- name: Setup Node.js 20.x
uses: actions/setup-node@master
with:
node-version: 16.x
node-version: 20.x

- name: Install Dependencies
run: yarn
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ jobs:
contents: write

steps:
- name: Set up node (16)
- name: Set up node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Checkout release branch (with history)
uses: actions/checkout@master
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ jobs:
# Block this workflow if run on a non-release branch.
if: github.event.inputs.release-branch == 'release' || endsWith(github.event.inputs.release-branch, '-releasebranch')
steps:
- name: Set up node (16)
- name: Set up node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Merge master into release
uses: actions/github-script@v6
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-tweet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ jobs:
steps:
- name: Checkout Repo
uses: actions/checkout@master
- name: Setup Node.js 16.x
- name: Setup Node.js 20.x
uses: actions/setup-node@master
with:
node-version: 16.x
node-version: 20.x
- name: Poll release notes page on devsite
run: node scripts/ci/poll_release_notes.js
env:
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/test-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ jobs:
run: |
npx @puppeteer/browsers install chrome@stable
- uses: actions/checkout@v3
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down Expand Up @@ -81,10 +81,10 @@ jobs:
name: build.tar.gz
- name: Unzip build artifact
run: tar xf build.tar.gz
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down Expand Up @@ -132,10 +132,10 @@ jobs:
name: build.tar.gz
- name: Unzip build artifact
run: tar xf build.tar.gz
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down Expand Up @@ -175,10 +175,10 @@ jobs:
name: build.tar.gz
- name: Unzip build artifact
run: tar xf build.tar.gz
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down Expand Up @@ -219,10 +219,10 @@ jobs:
name: build.tar.gz
- name: Unzip build artifact
run: tar xf build.tar.gz
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- run: cp config/ci.config.json config/project.json
- run: yarn
- run: yarn build:${{ matrix.persistence }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test-changed-auth.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down Expand Up @@ -88,10 +88,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-changed-fcm-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-changed-firestore-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ jobs:
rm -f "$output_file"
continue-on-error: true

- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/test-changed-firestore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand Down Expand Up @@ -84,10 +84,10 @@ jobs:
needs: build
if: ${{ needs.build.outputs.changed == 'true'}}
steps:
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand All @@ -112,10 +112,10 @@ jobs:
needs: build
if: ${{ needs.build.outputs.changed == 'true'}}
steps:
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand All @@ -142,10 +142,10 @@ jobs:
needs: build
if: ${{ github.event_name != 'pull_request' }}
steps:
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand Down Expand Up @@ -180,10 +180,10 @@ jobs:
run: |
sudo apt-get update
sudo apt-get install firefox
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Download build archive
uses: actions/download-artifact@v3
with:
Expand Down Expand Up @@ -219,10 +219,10 @@ jobs:
name: build.tar.gz
- name: Unzip build artifact
run: tar xf build.tar.gz
- name: Set up Node (16)
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: Test setup and yarn install
run: cp config/ci.config.json config/project.json
- name: Run tests
Expand Down
Loading