Fix chromedriver issue 2 #8045
Merged
Fix chromedriver issue 2 #8045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
requested review from
lisajian,
Xiaoshouzi-gh,
renkelvin,
sam-gc,
a team and
zwu52
as code owners
|
Changeset File Check
|
DellaBitta
approved these changes
Feb 26, 2024
Size Report 1Affected ProductsNo changes between base commit (9fa0e9f) and merge commit (48992be).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (9fa0e9f) and merge commit (48992be).Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're having some CI issues on npm install for auth tests. Seems to be related to a new url for downloading chrome.
puppeteer/puppeteer#11923
I bumped the
chromedriverNPM package to version 116.0.0 because I think it needs to be above 115 in order to use this env variable (see https://github.com/giggio/node-chromedriver?tab=readme-ov-file#for-versions--115) but starting with 117.0.0 it requires Node 18+ which we're not ready to convert our workflows to.