Skip to content

Fix chromedriver issue? #8039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/empty-bugs-cry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/auth': patch
---

Bump chromedriver version.
4 changes: 2 additions & 2 deletions .github/workflows/canary-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
with:
# Canary release script requires git history and tags.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Yarn install
run: yarn
- name: Deploy canary
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-changeset.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ jobs:
with:
# This makes Actions fetch all Git history so check_changeset script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Yarn install
run: yarn
- name: Run changeset script
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
with:
# get all history for the diff
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Yarn install
run: yarn
- name: Run doc generation (devsite docs)
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-pkg-paths.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Yarn install
run: yarn
- name: Yarn build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
with:
# get all history for the diff
fetch-depth: 0
- name: Set up node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Yarn install
run: yarn
- name: Run formatting script
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/health-metrics-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- uses: 'google-github-actions/auth@v0'
with:
credentials_json: '${{ secrets.GCP_SA_KEY }}'
Expand All @@ -58,7 +58,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- uses: 'google-github-actions/auth@v0'
with:
credentials_json: '${{ secrets.GCP_SA_KEY }}'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Set up node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: yarn install
run: yarn
- name: yarn lint
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/prerelease-manual-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ jobs:
with:
# Canary release script requires git history and tags.
fetch-depth: 0
- name: Set up node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Yarn install
run: yarn
- name: Deploy prerelease
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-log.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Setup Node.js 16.x
uses: actions/setup-node@master
with:
node-version: 16.x
node-version: 18.x

- name: Get PR number and send to tracker.
run: node scripts/ci/log-changesets.js
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Setup Node.js 16.x
uses: actions/setup-node@master
with:
node-version: 16.x
node-version: 18.x

- name: Install Dependencies
run: yarn
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ jobs:
contents: write

steps:
- name: Set up node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Checkout release branch (with history)
uses: actions/checkout@master
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ jobs:
# Block this workflow if run on a non-release branch.
if: github.event.inputs.release-branch == 'release' || endsWith(github.event.inputs.release-branch, '-releasebranch')
steps:
- name: Set up node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Merge master into release
uses: actions/github-script@v6
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-tweet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Setup Node.js 16.x
uses: actions/setup-node@master
with:
node-version: 16.x
node-version: 18.x
- name: Poll release notes page on devsite
run: node scripts/ci/poll_release_notes.js
env:
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/test-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ env:
# The default behavior of chromedriver uses the older Chrome download URLs. We need to override
# the beahvior to use the new URLs.
CHROMEDRIVER_CDNURL: https://googlechromelabs.github.io/
CHROMEDRIVER_CDNBINARIESURL: https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/
CHROMEDRIVER_CDNBINARIESURL: https://storage.googleapis.com/chrome-for-testing-public/
CHROME_VALIDATED_VERSION: linux-120.0.6099.71
CHROME_VERSION_MISMATCH_MESSAGE: "The Chrome version doesn't match the previously validated version. Consider updating CHROME_VALIDATED_VERSION in the GitHub workflow if tests pass."
artifactRetentionDays: 14
Expand All @@ -42,10 +42,10 @@ jobs:
run: |
npx @puppeteer/browsers install chrome@stable
- uses: actions/checkout@v3
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down Expand Up @@ -81,10 +81,10 @@ jobs:
name: build.tar.gz
- name: Unzip build artifact
run: tar xf build.tar.gz
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down Expand Up @@ -132,10 +132,10 @@ jobs:
name: build.tar.gz
- name: Unzip build artifact
run: tar xf build.tar.gz
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down Expand Up @@ -175,10 +175,10 @@ jobs:
name: build.tar.gz
- name: Unzip build artifact
run: tar xf build.tar.gz
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down Expand Up @@ -219,10 +219,10 @@ jobs:
name: build.tar.gz
- name: Unzip build artifact
run: tar xf build.tar.gz
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- run: cp config/ci.config.json config/project.json
- run: yarn
- run: yarn build:${{ matrix.persistence }}
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/test-changed-auth.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ env:
# The default behavior of chromedriver uses the older Chrome download URLs. We need to override
# the beahvior to use the new URLs.
CHROMEDRIVER_CDNURL: https://googlechromelabs.github.io/
CHROMEDRIVER_CDNBINARIESURL: https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/
CHROMEDRIVER_CDNBINARIESURL: https://storage.googleapis.com/chrome-for-testing-public/
CHROME_VALIDATED_VERSION: linux-120.0.6099.71
# Bump Node memory limit
NODE_OPTIONS: "--max_old_space_size=4096"
Expand Down Expand Up @@ -56,10 +56,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down Expand Up @@ -88,10 +88,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-changed-fcm-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-changed-firestore-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ jobs:
rm -f "$output_file"
continue-on-error: true

- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/test-changed-firestore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand Down Expand Up @@ -84,10 +84,10 @@ jobs:
needs: build
if: ${{ needs.build.outputs.changed == 'true'}}
steps:
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand All @@ -112,10 +112,10 @@ jobs:
needs: build
if: ${{ needs.build.outputs.changed == 'true'}}
steps:
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand All @@ -142,10 +142,10 @@ jobs:
needs: build
if: ${{ github.event_name != 'pull_request' }}
steps:
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand Down Expand Up @@ -180,10 +180,10 @@ jobs:
run: |
sudo apt-get update
sudo apt-get install firefox
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Download build archive
uses: actions/download-artifact@v3
with:
Expand Down Expand Up @@ -219,10 +219,10 @@ jobs:
name: build.tar.gz
- name: Unzip build artifact
run: tar xf build.tar.gz
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Test setup and yarn install
run: cp config/ci.config.json config/project.json
- name: Run tests
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-changed-misc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand Down
Loading