Catch transaction.done errors

[hsubox76]

The idb library we use has a done promise on all transactions, which can throw unhandled rejections. It must be included in all try/catch blocks in order to avoid an unhandled rejection.

This is part of the platform logging functionality, which should never throw or block user app functionality. This change ensures it will be caught along with all other transaction errors and converted to a console.warn.

[changeset-bot]

🦋 Changeset detected

Latest commit: 8ddc7e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/app	Patch
@firebase/app-compat	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[google-oss-bot]

Size Report ¹

Affected Products

• @firebase/app

  Type	Base (d8f4ea2)	Merge (3e7dff7)	Diff
  browser	14.7 kB	14.7 kB	+26 B (+0.2%)
  esm5	19.2 kB	19.3 kB	+44 B (+0.2%)
  main	20.1 kB	20.2 kB	+44 B (+0.2%)
  module	14.7 kB	14.7 kB	+26 B (+0.2%)

• bundle

  46 size changes

  Type	Base (d8f4ea2)	Merge (3e7dff7)	Diff
  analytics (logEvent)	44.0 kB	44.1 kB	+23 B (+0.1%)
  app-check (CustomProvider)	36.9 kB	36.9 kB	+23 B (+0.1%)
  app-check (ReCaptchaEnterpriseProvider)	39.4 kB	39.5 kB	+23 B (+0.1%)
  app-check (ReCaptchaV3Provider)	39.4 kB	39.4 kB	+23 B (+0.1%)
  auth (Anonymous)	73.8 kB	73.8 kB	+23 B (+0.0%)
  auth (EmailAndPassword)	82.0 kB	82.1 kB	+23 B (+0.0%)
  auth (GoogleFBTwitterGitHubPopup)	101 kB	101 kB	+23 B (+0.0%)
  auth (GooglePopup)	98.1 kB	98.1 kB	+23 B (+0.0%)
  auth (GoogleRedirect)	98.3 kB	98.3 kB	+23 B (+0.0%)
  auth (Phone)	84.4 kB	84.4 kB	+23 B (+0.0%)
  database (Append to a list of data)	149 kB	149 kB	+23 B (+0.0%)
  database (Filtering data)	147 kB	147 kB	+23 B (+0.0%)
  database (Listen for child events)	164 kB	164 kB	+23 B (+0.0%)
  database (Listen for value events + Detach listeners)	164 kB	164 kB	+23 B (+0.0%)
  database (Listen for value events)	164 kB	164 kB	+23 B (+0.0%)
  database (Read data once)	163 kB	163 kB	+23 B (+0.0%)
  database (Save data as transactions)	166 kB	166 kB	+23 B (+0.0%)
  database (Sort data)	149 kB	149 kB	+23 B (+0.0%)
  database (Write data)	148 kB	148 kB	+23 B (+0.0%)
  firestore (CSI Auto Indexing Disable and Delete)	268 kB	268 kB	+23 B (+0.0%)
  firestore (CSI Auto Indexing Enable)	268 kB	268 kB	+23 B (+0.0%)
  firestore (Persistence)	303 kB	303 kB	+23 B (+0.0%)
  firestore (Query Cursors)	246 kB	246 kB	+23 B (+0.0%)
  firestore (Query)	243 kB	243 kB	+23 B (+0.0%)
  firestore (Read data once)	231 kB	231 kB	+23 B (+0.0%)
  firestore (Read Write w Persistence)	321 kB	321 kB	+23 B (+0.0%)
  firestore (Realtime updates)	234 kB	234 kB	+23 B (+0.0%)
  firestore (Transaction)	211 kB	211 kB	+23 B (+0.0%)
  firestore (Write data)	211 kB	211 kB	+23 B (+0.0%)
  firestore-lite (Query Cursors)	89.4 kB	89.4 kB	+23 B (+0.0%)
  firestore-lite (Query)	85.5 kB	85.5 kB	+23 B (+0.0%)
  firestore-lite (Read data once)	61.7 kB	61.7 kB	+23 B (+0.0%)
  firestore-lite (Transaction)	86.6 kB	86.6 kB	+23 B (+0.0%)
  firestore-lite (Write data)	71.2 kB	71.3 kB	+23 B (+0.0%)
  functions (call)	31.4 kB	31.5 kB	+23 B (+0.1%)
  messaging (send + receive)	46.8 kB	46.8 kB	+23 B (+0.0%)
  performance (trace)	51.3 kB	51.3 kB	+23 B (+0.0%)
  remote-config (getAndFetch)	45.8 kB	45.8 kB	+23 B (+0.1%)
  storage (getBytes)	41.6 kB	41.6 kB	+23 B (+0.1%)
  storage (getDownloadURL)	43.6 kB	43.7 kB	+23 B (+0.1%)
  storage (getMetadata)	43.1 kB	43.1 kB	+23 B (+0.1%)
  storage (list + listAll)	42.5 kB	42.5 kB	+23 B (+0.1%)
  storage (updateMetadata)	43.4 kB	43.4 kB	+23 B (+0.1%)
  storage (uploadBytes)	48.2 kB	48.2 kB	+23 B (+0.0%)
  storage (uploadBytesResumable)	58.2 kB	58.2 kB	+23 B (+0.0%)
  storage (uploadString)	48.4 kB	48.4 kB	+23 B (+0.0%)

• firebase

  Type	Base (d8f4ea2)	Merge (3e7dff7)	Diff
  firebase-app-compat.js	29.2 kB	29.2 kB	+19 B (+0.1%)
  firebase-app.js	94.4 kB	94.5 kB	+123 B (+0.1%)
  firebase-compat.js	780 kB	780 kB	+19 B (+0.0%)
  firebase-performance-standalone-compat.es2017.js	90.4 kB	90.4 kB	+19 B (+0.0%)
  firebase-performance-standalone-compat.js	67.5 kB	67.6 kB	+52 B (+0.1%)

Test Logs

• Base (d8f4ea2): https://github.com/firebase/firebase-js-sdk/actions/runs/7672584914
• Merge (3e7dff7): https://github.com/firebase/firebase-js-sdk/actions/runs/7674364084

1. https://storage.googleapis.com/firebase-sdk-metric-reports/CMHnGWzQDa.html

[google-oss-bot]

Size Analysis Report ¹

This report is too large (140,758 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

• Base (d8f4ea2): https://github.com/firebase/firebase-js-sdk/actions/runs/7672584914
• Merge (3e7dff7): https://github.com/firebase/firebase-js-sdk/actions/runs/7674364084

1. https://storage.googleapis.com/firebase-sdk-metric-reports/5X29OA6Wny.html