Skip to content

[FirebaseServerApp] Add ServerApp to feature branch #7894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jan 8, 2024
Merged

[FirebaseServerApp] Add ServerApp to feature branch #7894

merged 30 commits into from
Jan 8, 2024

Conversation

DellaBitta
Copy link
Contributor

Discussion

Baseline addition of the FirebaseServerApp object. This PR is against a feature branch as is meant for incrememntal development review.

Testing

Added new FirebaseServerApp tests akin to the FirebaseApp tests.

API Changes

Will be part of the main feature branch merge to the main branch, when that takes place in 2024.

@DellaBitta
initial pass of additions
1216622
@DellaBitta
another pass, optional callback failures
2efe043
@DellaBitta
compilation fixes
fda3060
@DellaBitta
FirebaseServerAppImpl now extends FirebaseAppImpl
5fa9c21
@DellaBitta
removed Headers object, added three callbacks instead
0ef3bb2
@DellaBitta
added deleteOnDeref support
8cd1072
@DellaBitta
lint fixes
d42f676
@DellaBitta
deleteOnDeref type converted from WeakRef to object.
612f990
@DellaBitta
update cookie func signatures. Check for existence of FinalizationReg…
76f2fe1 
…istry
@DellaBitta
added baseline firebaseServerApp.test.ts
d68f986
@DellaBitta
update callback method siganatures with shorter names and alt undef p…
09e3157 
…arams
@DellaBitta
added some firebaseServerApp tests
3750aa4
@DellaBitta
Merge branch 'master' into ddb-server-app
316309c
@DellaBitta
format
6cc428b
@DellaBitta
Merge branch 'master' into ddb-server-app
53c15e2
@DellaBitta
rework builds, tests need updating
22b9bd9
@DellaBitta
another API update and doc generation
3c39866
@DellaBitta
Merge branch 'master' into ddb-server-app
d5e461e
@DellaBitta
reflect new API proposal in source
a7d111a
@DellaBitta
FirbaseServerAppSettings name?: undefined
0427934
@DellaBitta
merge master
db9b941
@DellaBitta
remove firebaseServerApp name
e146815
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 04af931

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 20, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (f478845)Merge (7676e91)Diff
    browser14.7 kB17.9 kB+3.18 kB (+21.6%)
    esm519.2 kB23.3 kB+4.09 kB (+21.3%)
    main20.1 kB24.3 kB+4.21 kB (+20.9%)
    module14.7 kB17.9 kB+3.18 kB (+21.6%)

  • bundle

    44 size changes

    TypeBase (f478845)Merge (7676e91)Diff
    analytics (logEvent)44.0 kB44.4 kB+357 B (+0.8%)
    app-check (CustomProvider)36.9 kB37.2 kB+357 B (+1.0%)
    app-check (ReCaptchaEnterpriseProvider)39.4 kB39.8 kB+357 B (+0.9%)
    app-check (ReCaptchaV3Provider)39.4 kB39.7 kB+357 B (+0.9%)
    auth (Anonymous)73.7 kB74.1 kB+357 B (+0.5%)
    auth (EmailAndPassword)81.6 kB81.9 kB+357 B (+0.4%)
    auth (GoogleFBTwitterGitHubPopup)100 kB101 kB+357 B (+0.4%)
    auth (GooglePopup)97.6 kB97.9 kB+357 B (+0.4%)
    auth (GoogleRedirect)97.8 kB98.2 kB+357 B (+0.4%)
    auth (Phone)84.0 kB84.3 kB+357 B (+0.4%)
    database (Append to a list of data)148 kB149 kB+357 B (+0.2%)
    database (Filtering data)147 kB148 kB+357 B (+0.2%)
    database (Listen for child events)164 kB164 kB+357 B (+0.2%)
    database (Listen for value events + Detach listeners)164 kB164 kB+357 B (+0.2%)
    database (Listen for value events)164 kB164 kB+357 B (+0.2%)
    database (Read data once)163 kB164 kB+357 B (+0.2%)
    database (Save data as transactions)166 kB166 kB+357 B (+0.2%)
    database (Sort data)149 kB149 kB+357 B (+0.2%)
    database (Write data)148 kB148 kB+357 B (+0.2%)
    firestore (Persistence)302 kB303 kB+357 B (+0.1%)
    firestore (Query Cursors)238 kB239 kB+357 B (+0.1%)
    firestore (Query)236 kB236 kB+357 B (+0.2%)
    firestore (Read data once)224 kB225 kB+357 B (+0.2%)
    firestore (Read Write w Persistence)321 kB321 kB+357 B (+0.1%)
    firestore (Realtime updates)226 kB227 kB+357 B (+0.2%)
    firestore (Transaction)204 kB204 kB+357 B (+0.2%)
    firestore (Write data)204 kB204 kB+357 B (+0.2%)
    firestore-lite (Query Cursors)89.3 kB89.7 kB+357 B (+0.4%)
    firestore-lite (Query)85.5 kB85.8 kB+357 B (+0.4%)
    firestore-lite (Read data once)61.6 kB62.0 kB+357 B (+0.6%)
    firestore-lite (Transaction)86.6 kB86.9 kB+357 B (+0.4%)
    firestore-lite (Write data)71.2 kB71.6 kB+357 B (+0.5%)
    functions (call)31.4 kB31.8 kB+357 B (+1.1%)
    messaging (send + receive)46.8 kB47.1 kB+357 B (+0.8%)
    performance (trace)51.2 kB51.6 kB+357 B (+0.7%)
    remote-config (getAndFetch)45.8 kB46.1 kB+357 B (+0.8%)
    storage (getBytes)41.5 kB41.9 kB+357 B (+0.9%)
    storage (getDownloadURL)43.6 kB44.0 kB+357 B (+0.8%)
    storage (getMetadata)43.1 kB43.4 kB+357 B (+0.8%)
    storage (list + listAll)42.5 kB42.8 kB+357 B (+0.8%)
    storage (updateMetadata)43.3 kB43.7 kB+357 B (+0.8%)
    storage (uploadBytes)48.2 kB48.5 kB+357 B (+0.7%)
    storage (uploadBytesResumable)58.1 kB58.5 kB+357 B (+0.6%)
    storage (uploadString)48.4 kB48.7 kB+357 B (+0.7%)

  • firebase

    TypeBase (f478845)Merge (7676e91)Diff
    firebase-app-compat.js29.2 kB31.3 kB+2.08 kB (+7.1%)
    firebase-app.js94.0 kB100 kB+6.10 kB (+6.5%)
    firebase-compat.js779 kB781 kB+2.08 kB (+0.3%)
    firebase-performance-standalone-compat.es2017.js90.4 kB93.1 kB+2.79 kB (+3.1%)
    firebase-performance-standalone-compat.js67.5 kB70.1 kB+2.57 kB (+3.8%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cCSCJoxtPX.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 20, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (172,723 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gHu3z4rTRU.html

@DellaBitta DellaBitta changed the title Ddb server app [FirebaseServerApp] Add ServerApp to feature branch Dec 21, 2023
@DellaBitta DellaBitta marked this pull request as ready for review January 8, 2024 19:32
@DellaBitta DellaBitta merged commit 3037b86 into feature-firebaseserverapp Jan 8, 2024
@DellaBitta DellaBitta deleted the ddb-server-app branch January 8, 2024 19:32
@firebase firebase locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels

@egilmorez egilmorez Awaiting requested review from egilmorez

@markarndt markarndt Awaiting requested review from markarndt

@kevinthecheung kevinthecheung Awaiting requested review from kevinthecheung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DellaBitta @google-oss-bot @jamesdaniels