Skip to content

Update isEqual for arrayUnion, arrayRemove, and increment #7861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Dec 12, 2023

fix 7706
Change the isEqual from identity equality check to comparing properties.

@milaGGL milaGGL requested review from a team as code owners December 12, 2023 16:37
Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: 0f64eeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 12, 2023

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (42bfb0b)Merge (bf49fc4)Diff
    browser374 kB375 kB+190 B (+0.1%)
    esm5360 kB360 kB+84 B (+0.0%)
    main576 kB576 kB+222 B (+0.0%)
    module374 kB375 kB+190 B (+0.1%)
    react-native375 kB375 kB+190 B (+0.1%)
  • @firebase/firestore-lite

    TypeBase (42bfb0b)Merge (bf49fc4)Diff
    browser109 kB109 kB+190 B (+0.2%)
    esm5106 kB106 kB+84 B (+0.1%)
    main150 kB150 kB+222 B (+0.1%)
    module109 kB109 kB+190 B (+0.2%)
    react-native109 kB109 kB+190 B (+0.2%)
  • firebase

    TypeBase (42bfb0b)Merge (bf49fc4)Diff
    firebase-compat.js779 kB779 kB+79 B (+0.0%)
    firebase-firestore-compat.js340 kB340 kB+387 B (+0.1%)
    firebase-firestore-lite.js116 kB117 kB+190 B (+0.2%)
    firebase-firestore.js434 kB434 kB+190 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5wgiNqwjaB.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 12, 2023

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • arrayRemove

      Size

      TypeBase (42bfb0b)Merge (bf49fc4)Diff
      size30.5 kB30.6 kB+74 B (+0.2%)
      size-with-ext-deps100 kB101 kB+372 B (+0.4%)

      External Dependency

      ModuleBase (42bfb0b)Merge (bf49fc4)Diff
      @firebase/util

      FirebaseError
      getModularInstance

      FirebaseError
      deepEqual
      getModularInstance

      + deepEqual

    • arrayUnion

      Size

      TypeBase (42bfb0b)Merge (bf49fc4)Diff
      size30.5 kB30.6 kB+74 B (+0.2%)
      size-with-ext-deps100 kB101 kB+372 B (+0.4%)

      External Dependency

      ModuleBase (42bfb0b)Merge (bf49fc4)Diff
      @firebase/util

      FirebaseError
      getModularInstance

      FirebaseError
      deepEqual
      getModularInstance

      + deepEqual

    • increment

      Size

      TypeBase (42bfb0b)Merge (bf49fc4)Diff
      size18.6 kB18.6 kB+23 B (+0.1%)
      size-with-ext-deps88.5 kB88.5 kB+23 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NgMGZXpMLe.html

@milaGGL milaGGL requested a review from a team as a code owner December 12, 2023 19:41
@milaGGL milaGGL merged commit a476c46 into master Dec 14, 2023
@milaGGL milaGGL deleted the mila/fixit-isEquals-to-arrayUnion-remove-increment branch December 14, 2023 14:53
@firebase firebase locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isEqual doesn't work on arrayUnion, arrayRemove, and increment
3 participants