Implement reCAPTCHA Enterprise flow for phone provider #7814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NhienLam
requested review from
lisajian,
prameshj,
renkelvin,
sam-gc and
a team
as code owners
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
NhienLam
requested review from
egilmorez,
markarndt and
kevinthecheung
as code owners
NhienLam
requested review from
Xiaoshouzi-gh
and removed request for
egilmorez,
markarndt and
kevinthecheung
renkelvin
reviewed
Mar 12, 2024
…to phone API requests (#7786) * Update injectRecaptchaFields to inject recaptcha fields into phone API requests * Fix lint * Rename captchaResp and fakeToken params * Format
NhienLam
force-pushed
the
nhienlam-rce-phone
branch
from
8e29413 to
124fbb3
Compare
renkelvin
approved these changes
Apr 8, 2024
|
|
||
| describe('platform_browser/providers/phone', () => { | ||
| let auth: TestAuth; | ||
|
|
||
| beforeEach(async () => { | ||
| fetch.setUp(); | ||
| auth = await testAuth(); | ||
| auth.settings.appVerificationDisabledForTesting = false; |
There was a problem hiding this comment.
Will the tests fail if it's set to true?
There was a problem hiding this comment.
Yes, tests with Recaptcha Enterprise enabled will fail if appVerificationDisabledForTesting is set to true.
(I mistakenly removed the test in the previous commit, just added it back)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
reCAPTCHA Enterprise + phone auth integration.
_verifyPhoneNumberto fetch and use reCAPTCHA Enterprise tokenhandleRecaptchaFlowto handle Phone ProviderRecaptchaEnterpriseVerifier.verify()to return a mock whenappVerificationDisabledForTestingis trueTesting