Skip to content

Disable all webdriver redirect tests #7801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,11 @@ browserDescribe('WebDriver integration with FirebaseUI', driver => {
expect(snap.uid).to.be.a('string');
});

it('allows google redirect sign in', async () => {
it('allows google redirect sign in', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

const page = await startUi();
await page.clickGoogleSignIn();
const widget = new IdPPage(driver.webDriver);
Expand Down
64 changes: 54 additions & 10 deletions packages/auth/test/integration/webdriver/redirect.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ browserDescribe('WebDriver redirect IdP test', driver => {
await driver.start('chrome');
});

it('allows users to sign in', async () => {
it('allows users to sign in', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

await driver.callNoWait(RedirectFunction.IDP_REDIRECT);
const widget = new IdPPage(driver.webDriver);

Expand Down Expand Up @@ -80,6 +84,10 @@ browserDescribe('WebDriver redirect IdP test', driver => {

// Redirect works with middleware for now
it('is blocked by middleware', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

if (driver.isCompatLayer()) {
console.warn('Skipping middleware tests in compat');
this.skip();
Expand All @@ -106,7 +114,11 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(await driver.getUserSnapshot()).to.be.null;
});

it('can link with another account account', async () => {
it('can link with another account account', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

// First, sign in anonymously
const { user: anonUser }: UserCredential = await driver.call(
AnonFunction.SIGN_IN_ANONYMOUSLY
Expand All @@ -128,7 +140,11 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(user.email).to.eq('[email protected]');
});

it('can be converted to a credential', async () => {
it('can be converted to a credential', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

// Start with redirect
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);
const widget = new IdPPage(driver.webDriver);
Expand Down Expand Up @@ -156,7 +172,11 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(second.providerData).to.eql(first.providerData);
});

it('handles account exists different credential errors', async () => {
it('handles account exists different credential errors', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

// Start with redirect and a verified account
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);
const widget = new IdPPage(driver.webDriver);
Expand Down Expand Up @@ -191,7 +211,11 @@ browserDescribe('WebDriver redirect IdP test', driver => {
]);
});

it('does not auto-upgrade anon accounts', async () => {
it('does not auto-upgrade anon accounts', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

const { user: anonUser }: UserCredential = await driver.call(
AnonFunction.SIGN_IN_ANONYMOUSLY
);
Expand All @@ -208,7 +232,11 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(curUser.uid).not.to.eq(anonUser.uid);
});

it('linking with anonymous user upgrades account', async () => {
it('linking with anonymous user upgrades account', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

const { user: anonUser }: UserCredential = await driver.call(
AnonFunction.SIGN_IN_ANONYMOUSLY
);
Expand All @@ -226,7 +254,11 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(curUser.isAnonymous).to.be.false;
});

it('is possible to link with different email', async () => {
it('is possible to link with different email', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

const { user: emailUser }: UserCredential = await driver.call(
EmailFunction.CREATE_USER,
'[email protected]'
Expand All @@ -249,7 +281,11 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(curUser.providerData.length).to.eq(2);
});

it('is possible to link with the same email', async () => {
it('is possible to link with the same email', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

const { user: emailUser }: UserCredential = await driver.call(
EmailFunction.CREATE_USER,
'[email protected]'
Expand Down Expand Up @@ -291,7 +327,11 @@ browserDescribe('WebDriver redirect IdP test', driver => {
await driver.call(CoreFunction.SIGN_OUT);
});

it('a user can sign in again', async () => {
it('a user can sign in again', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

// Sign in using pre-poulated user
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);

Expand All @@ -307,7 +347,11 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(user.email).to.eq(user1.email);
});

it('reauthenticate works for the correct user', async () => {
it('reauthenticate works for the correct user', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

// Sign in using pre-poulated user
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);

Expand Down