Skip to content

Tag PID to BQ delivery metric #7788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Tag PID to BQ delivery metric #7788

merged 5 commits into from
Nov 16, 2023

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Nov 15, 2023

tracker: b/297256818

@zwu52 zwu52 requested a review from a team as a code owner November 15, 2023 22:10
Copy link

changeset-bot bot commented Nov 15, 2023

🦋 Changeset detected

Latest commit: 5b0e179

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/messaging Patch
firebase Patch
@firebase/messaging-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 15, 2023

Size Report 1

Affected Products

  • @firebase/messaging-sw

    TypeBase (b2163b3)Merge (6fdf8ab)Diff
    main30.2 kB30.5 kB+259 B (+0.9%)
    module23.4 kB23.6 kB+261 B (+1.1%)
  • firebase

    TypeBase (b2163b3)Merge (6fdf8ab)Diff
    firebase-compat.js778 kB778 kB+130 B (+0.0%)
    firebase-messaging-compat.js38.3 kB38.4 kB+130 B (+0.3%)
    firebase-messaging-sw.js30.1 kB30.2 kB+142 B (+0.5%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OruI3VO1Fp.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 15, 2023

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a changeset in order to trigger a release, and needs a formatting pass (yarn format should do it).

@zwu52 zwu52 requested review from a team as code owners November 16, 2023 06:56
@zwu52 zwu52 requested a review from hsubox76 November 16, 2023 06:57
'@firebase/messaging': patch
---

Tag product id for big query metric logging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add internal, e.g. "Tag product id for internal bigquery metric logging"?

Copy link
Contributor

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:%0A - @firebase/logger%0A%0A Make sure this was intentional.

@zwu52 zwu52 merged commit b782bb2 into master Nov 16, 2023
@zwu52 zwu52 deleted the dma-product-id branch November 16, 2023 19:11
@google-oss-bot google-oss-bot mentioned this pull request Nov 20, 2023
@firebase firebase locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants