Firestore: Improve persistent cache index auto-creation tests by adding internal testing hooks #7585

dconeybe · 2023-08-24T15:33:46Z

This PR improves the integration tests for enablePersistentCacheIndexAutoCreation(), disablePersistentCacheIndexAutoCreation(), and deleteAllPersistentCacheIndexes() which were added in the previous PRs #7542 and #7587, to more thoroughly validate the behavior of persistent cache index auto-creation by adding and using "testing hooks" into the internals of the SDK.

changeset-bot · 2023-08-24T15:33:50Z

🦋 Changeset detected

Latest commit: 01ff39f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Patch
firebase	Patch
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2023-08-24T15:57:21Z

Size Report ¹

Affected Products

`@firebase/firestore`

Type	Base (`320e58c`)	Merge (`dd8ccd4`)	Diff
browser	375 kB	378 kB	+2.55 kB (+0.7%)
esm5	360 kB	363 kB	+2.84 kB (+0.8%)
main	577 kB	580 kB	+3.41 kB (+0.6%)
module	375 kB	378 kB	+2.55 kB (+0.7%)
react-native	376 kB	378 kB	+2.55 kB (+0.7%)

`bundle`

Type	Base (`320e58c`)	Merge (`dd8ccd4`)	Diff
firestore (Persistence)	302 kB	302 kB	+156 B (+0.1%)
firestore (Query Cursors)	239 kB	239 kB	+156 B (+0.1%)
firestore (Query)	237 kB	237 kB	+156 B (+0.1%)
firestore (Read data once)	224 kB	224 kB	+156 B (+0.1%)
firestore (Realtime updates)	226 kB	226 kB	+156 B (+0.1%)
firestore (Transaction)	204 kB	204 kB	+156 B (+0.1%)
firestore (Write data)	204 kB	204 kB	+156 B (+0.1%)

firebase
Type Base (320e58c) Merge (dd8ccd4) Diff
firebase-compat.js 779 kB 779 kB +156 B (+0.0%)
firebase-firestore-compat.js 341 kB 341 kB +156 B (+0.0%)
firebase-firestore.js 435 kB 437 kB +2.55 kB (+0.6%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/kNRtZhvLoP.html

google-oss-bot · 2023-08-24T16:27:50Z

Size Analysis Report ¹

Affected Products

`@firebase/firestore`

`_TestingHooks`

Size

Type	Base (`320e58c`)	Merge (`dd8ccd4`)	Diff
size	18.2 kB	90.6 kB	+72.4 kB (+397.5%)
size-with-ext-deps	87.8 kB	160 kB	+72.7 kB (+82.7%)

Dependency

Type Base (320e58c) Merge (dd8ccd4) Diff

functions

12 dependencies

__PRIVATE_argToString
__PRIVATE_cloneLongPollingOptions
__PRIVATE_configureFirestore
__PRIVATE_hardAssert
__PRIVATE_isIndexedDbTransactionError
__PRIVATE_logDebug
__PRIVATE_logError
__PRIVATE_randomBytes
__PRIVATE_validateIsNotUsedTogether
__PRIVATE_wrapInUserErrorIfRecoverable
fail
getDocument

115 dependencies

__PRIVATE__queryToTarget
__PRIVATE_applyArrayRemoveTransformOperation
__PRIVATE_applyArrayUnionTransformOperation
__PRIVATE_applyTransformOperationToLocalView
__PRIVATE_applyTransformOperationToRemoteDocument
__PRIVATE_argToString
__PRIVATE_arrayEquals
__PRIVATE_arrayValueContains
__PRIVATE_boundCompareToDocument
__PRIVATE_boundEquals
__PRIVATE_calculateOverlayMutation
__PRIVATE_canFallbackFromIndexedDbError
__PRIVATE_canonifyFilter
__PRIVATE_canonifyTarget
__PRIVATE_canonifyValue
__PRIVATE_cast
__PRIVATE_cloneLongPollingOptions
__PRIVATE_coercedFieldValuesArray
__PRIVATE_compareDocs
__PRIVATE_compareTimestamps
__PRIVATE_compositeFilterIsConjunction
__PRIVATE_compositeFilterIsFlat
__PRIVATE_compositeFilterIsFlatConjunction
__PRIVATE_computeTransformOperationBaseValue
__PRIVATE_configureFirestore
__PRIVATE_convertOverlayedDocumentMapToDocumentMap
__PRIVATE_convertQueryTargetToQuery
__PRIVATE_debugCast
__PRIVATE_deepClone
__PRIVATE_documentKeySet
__PRIVATE_ensureOfflineComponents
__PRIVATE_extractDocumentKeysFromArrayValue
__PRIVATE_extractLocalPathFromResourceName
__PRIVATE_fieldTransformEquals
__PRIVATE_filterEquals
__PRIVATE_fromBundledQuery
__PRIVATE_fromFieldPathReference
__PRIVATE_fromFilter
__PRIVATE_fromQueryPath
__PRIVATE_fromResourceName
__PRIVATE_fromVersion
__PRIVATE_getFirstOrderByField
__PRIVATE_getInequalityFilterField
__PRIVATE_getLocalStore
__PRIVATE_getLocalWriteTime
__PRIVATE_getLogLevel
__PRIVATE_getPatch
__PRIVATE_getPreviousValue
__PRIVATE_hardAssert
__PRIVATE_indexOffsetComparator
__PRIVATE_isCollectionGroupQuery
__PRIVATE_isIndexedDbTransactionError
__PRIVATE_isMapValue
__PRIVATE_isMaxValue
__PRIVATE_isNegativeZero
__PRIVATE_isNullOrUndefined
__PRIVATE_isServerTimestamp
__PRIVATE_isValidResourceName
__PRIVATE_localStoreHandleUserChange
__PRIVATE_localTransformResults
__PRIVATE_logDebug
__PRIVATE_logError
__PRIVATE_logWarn
__PRIVATE_mutableDocumentMap
__PRIVATE_mutationApplyToLocalView
__PRIVATE_mutationApplyToRemoteDocument
__PRIVATE_mutationEquals
__PRIVATE_newDocumentKeyMap
__PRIVATE_newIndexOffsetFromDocument
__PRIVATE_newIndexOffsetSuccessorFromReadTime
__PRIVATE_newLocalStore
__PRIVATE_newMutationMap
__PRIVATE_newOverlayMap
__PRIVATE_newQuery
__PRIVATE_newQueryComparator
__PRIVATE_newSerializer
__PRIVATE_newTarget
__PRIVATE_normalizeByteString
__PRIVATE_normalizeNumber
__PRIVATE_normalizeTimestamp
__PRIVATE_objectSize
__PRIVATE_orderByEquals
__PRIVATE_preconditionIsValidForDocument
__PRIVATE_primitiveComparator
__PRIVATE_queryMatches
__PRIVATE_queryMatchesAllDocuments
__PRIVATE_queryNormalizedOrderBy
__PRIVATE_queryToTarget
__PRIVATE_queryWithLimit
__PRIVATE_randomBytes
__PRIVATE_registerCallback
__PRIVATE_serverTransformResults
__PRIVATE_setOfflineComponentProvider
__PRIVATE_stringifyFilter
__PRIVATE_stringifyQuery
__PRIVATE_targetEquals
__PRIVATE_targetIdSet
__PRIVATE_toDouble
__PRIVATE_toInteger
__PRIVATE_typeOrder
__PRIVATE_validateIsNotUsedTogether
__PRIVATE_valueCompare
__PRIVATE_valueDescription
__PRIVATE_valueEquals
__PRIVATE_wrapInUserErrorIfRecoverable
asNumber
canonicalId
documentMap
ensureFirestoreConfigured
fail
forEach
getDocument
isArray
isEmpty
isInteger

103 dependency diffs

+ __PRIVATE__queryToTarget
+ __PRIVATE_applyArrayRemoveTransformOperation
+ __PRIVATE_applyArrayUnionTransformOperation
+ __PRIVATE_applyTransformOperationToLocalView
+ __PRIVATE_applyTransformOperationToRemoteDocument
+ __PRIVATE_arrayEquals
+ __PRIVATE_arrayValueContains
+ __PRIVATE_boundCompareToDocument
+ __PRIVATE_boundEquals
+ __PRIVATE_calculateOverlayMutation
+ __PRIVATE_canFallbackFromIndexedDbError
+ __PRIVATE_canonifyFilter
+ __PRIVATE_canonifyTarget
+ __PRIVATE_canonifyValue
+ __PRIVATE_cast
+ __PRIVATE_coercedFieldValuesArray
+ __PRIVATE_compareDocs
+ __PRIVATE_compareTimestamps
+ __PRIVATE_compositeFilterIsConjunction
+ __PRIVATE_compositeFilterIsFlat
+ __PRIVATE_compositeFilterIsFlatConjunction
+ __PRIVATE_computeTransformOperationBaseValue
+ __PRIVATE_convertOverlayedDocumentMapToDocumentMap
+ __PRIVATE_convertQueryTargetToQuery
+ __PRIVATE_debugCast
+ __PRIVATE_deepClone
+ __PRIVATE_documentKeySet
+ __PRIVATE_ensureOfflineComponents
+ __PRIVATE_extractDocumentKeysFromArrayValue
+ __PRIVATE_extractLocalPathFromResourceName
+ __PRIVATE_fieldTransformEquals
+ __PRIVATE_filterEquals
+ __PRIVATE_fromBundledQuery
+ __PRIVATE_fromFieldPathReference
+ __PRIVATE_fromFilter
+ __PRIVATE_fromQueryPath
+ __PRIVATE_fromResourceName
+ __PRIVATE_fromVersion
+ __PRIVATE_getFirstOrderByField
+ __PRIVATE_getInequalityFilterField
+ __PRIVATE_getLocalStore
+ __PRIVATE_getLocalWriteTime
+ __PRIVATE_getLogLevel
+ __PRIVATE_getPatch
+ __PRIVATE_getPreviousValue
+ __PRIVATE_indexOffsetComparator
+ __PRIVATE_isCollectionGroupQuery
+ __PRIVATE_isMapValue
+ __PRIVATE_isMaxValue
+ __PRIVATE_isNegativeZero
+ __PRIVATE_isNullOrUndefined
+ __PRIVATE_isServerTimestamp
+ __PRIVATE_isValidResourceName
+ __PRIVATE_localStoreHandleUserChange
+ __PRIVATE_localTransformResults
+ __PRIVATE_logWarn
+ __PRIVATE_mutableDocumentMap
+ __PRIVATE_mutationApplyToLocalView
+ __PRIVATE_mutationApplyToRemoteDocument
+ __PRIVATE_mutationEquals
+ __PRIVATE_newDocumentKeyMap
+ __PRIVATE_newIndexOffsetFromDocument
+ __PRIVATE_newIndexOffsetSuccessorFromReadTime
+ __PRIVATE_newLocalStore
+ __PRIVATE_newMutationMap
+ __PRIVATE_newOverlayMap
+ __PRIVATE_newQuery
+ __PRIVATE_newQueryComparator
+ __PRIVATE_newSerializer
+ __PRIVATE_newTarget
+ __PRIVATE_normalizeByteString
+ __PRIVATE_normalizeNumber
+ __PRIVATE_normalizeTimestamp
+ __PRIVATE_objectSize
+ __PRIVATE_orderByEquals
+ __PRIVATE_preconditionIsValidForDocument
+ __PRIVATE_primitiveComparator
+ __PRIVATE_queryMatches
+ __PRIVATE_queryMatchesAllDocuments
+ __PRIVATE_queryNormalizedOrderBy
+ __PRIVATE_queryToTarget
+ __PRIVATE_queryWithLimit
+ __PRIVATE_registerCallback
+ __PRIVATE_serverTransformResults
+ __PRIVATE_setOfflineComponentProvider
+ __PRIVATE_stringifyFilter
+ __PRIVATE_stringifyQuery
+ __PRIVATE_targetEquals
+ __PRIVATE_targetIdSet
+ __PRIVATE_toDouble
+ __PRIVATE_toInteger
+ __PRIVATE_typeOrder
+ __PRIVATE_valueCompare
+ __PRIVATE_valueDescription
+ __PRIVATE_valueEquals
+ asNumber
+ canonicalId
+ documentMap
+ ensureFirestoreConfigured
+ forEach
+ isArray
+ isEmpty
+ isInteger

classes

22 dependencies

AppCheckToken
DatabaseId
DatabaseInfo
DelayedOperation
Firestore
Firestore$1
FirestoreClient
FirestoreError
FirestoreSettingsImpl
TestingHooks
User
__PRIVATE_AsyncQueueImpl
__PRIVATE_AutoId
__PRIVATE_Deferred
__PRIVATE_EmptyAuthCredentialsProvider
__PRIVATE_ExponentialBackoff
__PRIVATE_FirebaseAppCheckTokenProvider
__PRIVATE_FirebaseAuthCredentialsProvider
__PRIVATE_FirstPartyAuthCredentialsProvider
__PRIVATE_FirstPartyToken
__PRIVATE_OAuthToken
__PRIVATE_TestingHooksSpiImpl

97 dependencies

AppCheckToken
BasePath
Bound
ByteString
CompositeFilter
DatabaseId
DatabaseInfo
DelayedOperation
DocumentKey
FieldFilter
FieldMask
FieldPath$1
Filter
Firestore
Firestore$1
FirestoreClient
FirestoreError
FirestoreSettingsImpl
IndexOffset
JsonProtoSerializer
LLRBNode
LocalDocumentsView
MemoryOfflineComponentProvider
MutableDocument
Mutation
MutationBatch
ObjectMap
ObjectValue
OrderBy
Overlay
OverlayedDocument
PersistencePromise
PersistenceTransaction
Precondition
Query
QueryContext
RemoteDocumentChangeBuffer
ResourcePath
SnapshotVersion
SortedMap
SortedMapIterator
SortedSet
SortedSetIterator
TestingHooks
TestingHooks$2
TestingHooks$3
Timestamp
TransformOperation
User
__PRIVATE_ArrayContainsAnyFilter
__PRIVATE_ArrayContainsFilter
__PRIVATE_ArrayRemoveTransformOperation
__PRIVATE_ArrayUnionTransformOperation
__PRIVATE_AsyncQueueImpl
__PRIVATE_AutoId
__PRIVATE_Base64DecodeError
__PRIVATE_Deferred
__PRIVATE_DeleteMutation
__PRIVATE_DocReference
__PRIVATE_EmptyAuthCredentialsProvider
__PRIVATE_ExponentialBackoff
__PRIVATE_FirebaseAppCheckTokenProvider
__PRIVATE_FirebaseAuthCredentialsProvider
__PRIVATE_FirstPartyAuthCredentialsProvider
__PRIVATE_FirstPartyToken
__PRIVATE_InFilter
__PRIVATE_KeyFieldFilter
__PRIVATE_KeyFieldInFilter
__PRIVATE_KeyFieldNotInFilter
__PRIVATE_ListenSequence
__PRIVATE_LocalClientState
__PRIVATE_LocalSerializer
__PRIVATE_LocalStoreImpl
__PRIVATE_MemoryBundleCache
__PRIVATE_MemoryCollectionParentIndex
__PRIVATE_MemoryDocumentOverlayCache
__PRIVATE_MemoryEagerDelegate
__PRIVATE_MemoryIndexManager
__PRIVATE_MemoryMutationQueue
__PRIVATE_MemoryPersistence
__PRIVATE_MemoryRemoteDocumentCacheImpl
__PRIVATE_MemoryRemoteDocumentChangeBuffer
__PRIVATE_MemorySharedClientState
__PRIVATE_MemoryTargetCache
__PRIVATE_MemoryTransaction
__PRIVATE_NotInFilter
__PRIVATE_NumericIncrementTransformOperation
__PRIVATE_OAuthToken
__PRIVATE_PatchMutation
__PRIVATE_QueryEngine
__PRIVATE_QueryImpl
__PRIVATE_ReferenceSet
__PRIVATE_ServerTimestampTransform
__PRIVATE_SetMutation
__PRIVATE_TargetIdGenerator
__PRIVATE_TargetImpl
__PRIVATE_TestingHooksSpiImpl

75 dependency diffs

+ BasePath
+ Bound
+ ByteString
+ CompositeFilter
+ DocumentKey
+ FieldFilter
+ FieldMask
+ FieldPath$1
+ Filter
+ IndexOffset
+ JsonProtoSerializer
+ LLRBNode
+ LocalDocumentsView
+ MemoryOfflineComponentProvider
+ MutableDocument
+ Mutation
+ MutationBatch
+ ObjectMap
+ ObjectValue
+ OrderBy
+ Overlay
+ OverlayedDocument
+ PersistencePromise
+ PersistenceTransaction
+ Precondition
+ Query
+ QueryContext
+ RemoteDocumentChangeBuffer
+ ResourcePath
+ SnapshotVersion
+ SortedMap
+ SortedMapIterator
+ SortedSet
+ SortedSetIterator
+ TestingHooks$2
+ TestingHooks$3
+ Timestamp
+ TransformOperation
+ __PRIVATE_ArrayContainsAnyFilter
+ __PRIVATE_ArrayContainsFilter
+ __PRIVATE_ArrayRemoveTransformOperation
+ __PRIVATE_ArrayUnionTransformOperation
+ __PRIVATE_Base64DecodeError
+ __PRIVATE_DeleteMutation
+ __PRIVATE_DocReference
+ __PRIVATE_InFilter
+ __PRIVATE_KeyFieldFilter
+ __PRIVATE_KeyFieldInFilter
+ __PRIVATE_KeyFieldNotInFilter
+ __PRIVATE_ListenSequence
+ __PRIVATE_LocalClientState
+ __PRIVATE_LocalSerializer
+ __PRIVATE_LocalStoreImpl
+ __PRIVATE_MemoryBundleCache
+ __PRIVATE_MemoryCollectionParentIndex
+ __PRIVATE_MemoryDocumentOverlayCache
+ __PRIVATE_MemoryEagerDelegate
+ __PRIVATE_MemoryIndexManager
+ __PRIVATE_MemoryMutationQueue
+ __PRIVATE_MemoryPersistence
+ __PRIVATE_MemoryRemoteDocumentCacheImpl
+ __PRIVATE_MemoryRemoteDocumentChangeBuffer
+ __PRIVATE_MemorySharedClientState
+ __PRIVATE_MemoryTargetCache
+ __PRIVATE_MemoryTransaction
+ __PRIVATE_NotInFilter
+ __PRIVATE_NumericIncrementTransformOperation
+ __PRIVATE_PatchMutation
+ __PRIVATE_QueryEngine
+ __PRIVATE_QueryImpl
+ __PRIVATE_ReferenceSet
+ __PRIVATE_ServerTimestampTransform
+ __PRIVATE_SetMutation
+ __PRIVATE_TargetIdGenerator
+ __PRIVATE_TargetImpl

variables

D
S
Se
ae
b
ce
me
ue
w

16 dependencies

C
D
S
Se
_e
ae
b
ce
ee
ie
me
oe
re
te
ue
w

+ C
+ _e
+ ee
+ ie
+ oe
+ re
+ te

addDoc
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 123 kB 123 kB +156 B (+0.1%)
size-with-ext-deps 194 kB 194 kB +156 B (+0.1%)
deleteAllPersistentCacheIndexes
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 87.4 kB 87.6 kB +166 B (+0.2%)
size-with-ext-deps 157 kB 157 kB +166 B (+0.1%)
deleteDoc
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 114 kB 114 kB +156 B (+0.1%)
size-with-ext-deps 185 kB 185 kB +156 B (+0.1%)
disableNetwork
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 103 kB 103 kB +156 B (+0.2%)
size-with-ext-deps 173 kB 173 kB +156 B (+0.1%)
disablePersistentCacheIndexAutoCreation
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 87.4 kB 87.5 kB +166 B (+0.2%)
size-with-ext-deps 157 kB 157 kB +166 B (+0.1%)
enableIndexedDbPersistence
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 186 kB 186 kB +156 B (+0.1%)
size-with-ext-deps 257 kB 258 kB +156 B (+0.1%)
enableMultiTabIndexedDbPersistence
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 221 kB 222 kB +156 B (+0.1%)
size-with-ext-deps 293 kB 293 kB +156 B (+0.1%)
enableNetwork
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 103 kB 103 kB +156 B (+0.2%)
size-with-ext-deps 173 kB 173 kB +156 B (+0.1%)
enablePersistentCacheIndexAutoCreation
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 87.4 kB 87.5 kB +166 B (+0.2%)
size-with-ext-deps 157 kB 157 kB +166 B (+0.1%)
executeWrite
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 113 kB 114 kB +156 B (+0.1%)
size-with-ext-deps 184 kB 184 kB +156 B (+0.1%)
getAggregateFromServer
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 110 kB 110 kB +156 B (+0.1%)
size-with-ext-deps 180 kB 180 kB +156 B (+0.1%)
getCountFromServer
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 110 kB 110 kB +156 B (+0.1%)
size-with-ext-deps 180 kB 180 kB +156 B (+0.1%)
getDoc
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 143 kB 143 kB +156 B (+0.1%)
size-with-ext-deps 214 kB 214 kB +156 B (+0.1%)
getDocFromCache
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 94.8 kB 95.0 kB +156 B (+0.2%)
size-with-ext-deps 165 kB 165 kB +156 B (+0.1%)
getDocFromServer
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 143 kB 143 kB +156 B (+0.1%)
size-with-ext-deps 214 kB 214 kB +156 B (+0.1%)
getDocs
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 145 kB 145 kB +156 B (+0.1%)
size-with-ext-deps 215 kB 215 kB +156 B (+0.1%)
getDocsFromCache
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 102 kB 103 kB +156 B (+0.2%)
size-with-ext-deps 172 kB 173 kB +156 B (+0.1%)
getDocsFromServer
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 145 kB 145 kB +156 B (+0.1%)
size-with-ext-deps 215 kB 215 kB +156 B (+0.1%)
loadBundle
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 112 kB 112 kB +156 B (+0.1%)
size-with-ext-deps 182 kB 182 kB +156 B (+0.1%)
memoryEagerGarbageCollector
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 85.4 kB 85.5 kB +156 B (+0.2%)
size-with-ext-deps 155 kB 155 kB +156 B (+0.1%)
memoryLocalCache
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 99.6 kB 99.8 kB +156 B (+0.2%)
size-with-ext-deps 170 kB 170 kB +156 B (+0.1%)
memoryLruGarbageCollector
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 91.9 kB 92.0 kB +156 B (+0.2%)
size-with-ext-deps 162 kB 162 kB +156 B (+0.1%)
Dependency
Type Base (320e58c) Merge (dd8ccd4) Diff
variables
16 dependencies
C D S Te _e ae b ee ie me oe re te ue v w
16 dependencies
C D S _e ae b de ee ie me oe re te ue v w
+ de - Te
namedQuery
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 88.3 kB 88.5 kB +156 B (+0.2%)
size-with-ext-deps 158 kB 158 kB +156 B (+0.1%)
onSnapshot
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 145 kB 146 kB +156 B (+0.1%)
size-with-ext-deps 216 kB 216 kB +156 B (+0.1%)
onSnapshotsInSync
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 135 kB 135 kB +156 B (+0.1%)
size-with-ext-deps 205 kB 206 kB +156 B (+0.1%)
persistentLocalCache
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 183 kB 183 kB +156 B (+0.1%)
size-with-ext-deps 255 kB 255 kB +156 B (+0.1%)
persistentMultipleTabManager
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 218 kB 218 kB +156 B (+0.1%)
size-with-ext-deps 290 kB 290 kB +156 B (+0.1%)
persistentSingleTabManager
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 183 kB 183 kB +156 B (+0.1%)
size-with-ext-deps 254 kB 254 kB +156 B (+0.1%)
runTransaction
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 123 kB 123 kB +156 B (+0.1%)
size-with-ext-deps 194 kB 194 kB +156 B (+0.1%)
setDoc
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 122 kB 123 kB +156 B (+0.1%)
size-with-ext-deps 193 kB 193 kB +156 B (+0.1%)
setIndexConfiguration
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 90.9 kB 91.1 kB +156 B (+0.2%)
size-with-ext-deps 161 kB 161 kB +156 B (+0.1%)
updateDoc
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 123 kB 123 kB +156 B (+0.1%)
size-with-ext-deps 193 kB 194 kB +156 B (+0.1%)
waitForPendingWrites
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 103 kB 103 kB +156 B (+0.2%)
size-with-ext-deps 173 kB 173 kB +156 B (+0.1%)
writeBatch
Size
Type Base (320e58c) Merge (dd8ccd4) Diff
size 125 kB 125 kB +156 B (+0.1%)
size-with-ext-deps 195 kB 195 kB +156 B (+0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/Cva4huL4LL.html

…teAllIndexesNoTestingHooks

…ng internal testing hooks

cherylEnkidu · 2023-08-25T17:50:48Z

Link to the internal ticket: b/297542938

…CreationTestingHooks

dconeybe added the api: firestore label Aug 24, 2023

dconeybe self-assigned this Aug 24, 2023

Base automatically changed from dconeybe/ClientSideIndexAutoCreation to master August 24, 2023 17:26

dconeybe force-pushed the dconeybe/ClientSideIndexAutoCreationTestingHooks branch from 2473ea2 to 75df024 Compare August 24, 2023 17:36

dconeybe added 2 commits August 24, 2023 16:03

Firestore: deleteAllPersistentCacheIndexes() added, but hidden for now

d00fe82

Merge remote-tracking branch 'origin/master' into ClientSideIndexDele…

5a159f3

…teAllIndexesNoTestingHooks

dconeybe changed the title ~~Firestore: Improve integration tests for enable/disablePersistentCacheIndexAutoCreation()~~ Firestore: Improve persistent cache index auto-creation tests by adding internal testing hooks Aug 24, 2023

Firestore: Improve persistent cache index auto-creation tests by addi…

a92925c

…ng internal testing hooks

dconeybe force-pushed the dconeybe/ClientSideIndexAutoCreationTestingHooks branch from 75df024 to a92925c Compare August 24, 2023 20:17

dconeybe changed the base branch from master to dconeybe/ClientSideIndexDeleteAllIndexesNoTestingHooks August 24, 2023 20:18

dconeybe mentioned this pull request Aug 24, 2023

deleteAllPersistentCacheIndexes() implemented (but hidden for now) #7586

Closed

Base automatically changed from dconeybe/ClientSideIndexDeleteAllIndexesNoTestingHooks to master August 25, 2023 19:25

dconeybe added 2 commits August 25, 2023 15:27

Merge remote-tracking branch 'origin/master' into ClientSideIndexAuto…

1e95830

…CreationTestingHooks

Merge remote-tracking branch 'origin/master' into ClientSideIndexAuto…

01ff39f

…CreationTestingHooks

Firestore: Improve persistent cache index auto-creation tests by adding internal testing hooks #7585

Are you sure you want to change the base?

Firestore: Improve persistent cache index auto-creation tests by adding internal testing hooks #7585

Conversation

dconeybe commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

google-oss-bot commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/firestore

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/firestore

_TestingHooks

addDoc

deleteAllPersistentCacheIndexes

deleteDoc

disableNetwork

disablePersistentCacheIndexAutoCreation

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

enablePersistentCacheIndexAutoCreation

executeWrite

getAggregateFromServer

getCountFromServer

getDoc

getDocFromCache

getDocFromServer

getDocs

getDocsFromCache

getDocsFromServer

loadBundle

memoryEagerGarbageCollector

memoryLocalCache

memoryLruGarbageCollector

namedQuery

onSnapshot

onSnapshotsInSync

persistentLocalCache

persistentMultipleTabManager

persistentSingleTabManager

runTransaction

setDoc

setIndexConfiguration

updateDoc

waitForPendingWrites

writeBatch

Test Logs

Uh oh!

cherylEnkidu commented Aug 25, 2023

Uh oh!

Uh oh!

dconeybe commented Aug 24, 2023 •

edited

Loading

changeset-bot bot commented Aug 24, 2023 •

edited

Loading

google-oss-bot commented Aug 24, 2023 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`bundle`

`firebase`

google-oss-bot commented Aug 24, 2023 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`_TestingHooks`

`addDoc`

`deleteAllPersistentCacheIndexes`

`deleteDoc`

`disableNetwork`

`disablePersistentCacheIndexAutoCreation`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`enablePersistentCacheIndexAutoCreation`

`executeWrite`

`getAggregateFromServer`

`getCountFromServer`

`getDoc`

`getDocFromCache`

`getDocFromServer`

`getDocs`

`getDocsFromCache`

`getDocsFromServer`

`loadBundle`

`memoryEagerGarbageCollector`

`memoryLocalCache`

`memoryLruGarbageCollector`

`namedQuery`

`onSnapshot`

`onSnapshotsInSync`

`persistentLocalCache`

`persistentMultipleTabManager`

`persistentSingleTabManager`

`runTransaction`

`setDoc`

`setIndexConfiguration`

`updateDoc`

`waitForPendingWrites`

`writeBatch`