Skip to content

Fix how we enable fetch streams. #7569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2023
Merged

Fix how we enable fetch streams. #7569

merged 2 commits into from
Aug 18, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Aug 17, 2023 •
edited
Loading

Fixes: #6118

@wu-hui wu-hui requested review from a team as code owners August 17, 2023 20:48
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 47cc39e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/firestore Patch
@firebase/webchannel-wrapper Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 17, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (345d198)Merge (2b2e2fb)Diff
    browser371 kB371 kB-46 B (-0.0%)
    esm5356 kB356 kB-47 B (-0.0%)
    module371 kB371 kB-46 B (-0.0%)
    react-native371 kB371 kB-47 B (-0.0%)

  • bundle

    TypeBase (345d198)Merge (2b2e2fb)Diff
    firestore (Persistence)300 kB300 kB-17 B (-0.0%)
    firestore (Query Cursors)238 kB238 kB-17 B (-0.0%)
    firestore (Query)235 kB235 kB-17 B (-0.0%)
    firestore (Read data once)223 kB223 kB-17 B (-0.0%)
    firestore (Realtime updates)225 kB225 kB-17 B (-0.0%)
    firestore (Transaction)203 kB203 kB-17 B (-0.0%)
    firestore (Write data)203 kB203 kB-17 B (-0.0%)

  • firebase

    TypeBase (345d198)Merge (2b2e2fb)Diff
    firebase-compat.js777 kB777 kB-13 B (-0.0%)
    firebase-firestore-compat.js339 kB339 kB-13 B (-0.0%)
    firebase-firestore.js430 kB430 kB+15 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IBj30npRK3.html

@wu-hui wu-hui requested a review from a team as a code owner August 17, 2023 21:17
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 17, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (128,016 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WccpSDz1eM.html

dconeybe
dconeybe approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you didn't explicitly request my review but I stumbled across this and it looks great! I'm excited to see this fix get merged.

@wu-hui wu-hui merged commit 78d2738 into master Aug 18, 2023
@wu-hui wu-hui deleted the wuandy/WCMemoryFix branch August 18, 2023 17:59
@google-oss-bot google-oss-bot mentioned this pull request Aug 22, 2023
Merged
@atsjo atsjo mentioned this pull request Aug 23, 2023
Closed
@wu-hui wu-hui mentioned this pull request Aug 29, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firebase is keep crashing because of OOM on mobile Safari
3 participants
@wu-hui @google-oss-bot @dconeybe